You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/07/01 06:48:21 UTC
Re: Review Request 70889: Wrapped isolators in `IsolatorTracker`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70889/#review216260
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 586-589 (patched)
<https://reviews.apache.org/r/70889/#comment303390>
Why do we need a dedicated for loop to do this? Can we just do it when each isolator is created (line 549 and line 563)?
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70889/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 10:49 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-9841
> https://issues.apache.org/jira/browse/MESOS-9841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch wraps every isolator in instance of `IsolatorTracker` class.
> If an isolator gets stuck in some operation, `pendingFutures` will
> return the isolator name, method name along with its arguments such as
> `containerId`, `pid`, etc.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 043244841a73fa3f5f7119bc38f6d3a04be8990b
>
>
> Diff: https://reviews.apache.org/r/70889/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>