You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Dave Beech (JIRA)" <ji...@apache.org> on 2012/06/18 10:01:46 UTC
[jira] [Created] (MRUNIT-120) Counter tests should support
wildcard/regex names
Dave Beech created MRUNIT-120:
---------------------------------
Summary: Counter tests should support wildcard/regex names
Key: MRUNIT-120
URL: https://issues.apache.org/jira/browse/MRUNIT-120
Project: MRUnit
Issue Type: Improvement
Affects Versions: 1.0.0
Reporter: Dave Beech
Priority: Minor
>From Bertrand Dechoux via user mailing list.
"The issue is that I might no know the name of the counters because they are dynamic. Even the group name is kind of dynamic because for warning counters, I use the class name and so it might change after refactoring."
Currently it is difficult to test counters with dynamically generated names. Also, as Bertrand mentioned in the email, hardcoding names can make tests brittle and break after code refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (MRUNIT-120) Counter tests should support
wildcard/regex names
Posted by "Dave Beech (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Beech closed MRUNIT-120.
-----------------------------
Resolution: Not A Problem
Closed as there's no requirement to do this at the moment
> Counter tests should support wildcard/regex names
> -------------------------------------------------
>
> Key: MRUNIT-120
> URL: https://issues.apache.org/jira/browse/MRUNIT-120
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Dave Beech
> Priority: Minor
>
> From Bertrand Dechoux via user mailing list.
> "The issue is that I might no know the name of the counters because they are dynamic. Even the group name is kind of dynamic because for warning counters, I use the class name and so it might change after refactoring."
> Currently it is difficult to test counters with dynamically generated names. Also, as Bertrand mentioned in the email, hardcoding names can make tests brittle and break after code refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-120) Counter tests should support
wildcard/regex names
Posted by "Jim Donofrio (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425709#comment-13425709 ]
Jim Donofrio commented on MRUNIT-120:
-------------------------------------
Yes it doesnt seem necessary
> Counter tests should support wildcard/regex names
> -------------------------------------------------
>
> Key: MRUNIT-120
> URL: https://issues.apache.org/jira/browse/MRUNIT-120
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Dave Beech
> Priority: Minor
>
> From Bertrand Dechoux via user mailing list.
> "The issue is that I might no know the name of the counters because they are dynamic. Even the group name is kind of dynamic because for warning counters, I use the class name and so it might change after refactoring."
> Currently it is difficult to test counters with dynamically generated names. Also, as Bertrand mentioned in the email, hardcoding names can make tests brittle and break after code refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-120) Counter tests should support
wildcard/regex names
Posted by "Bertrand Dechoux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425533#comment-13425533 ]
Bertrand Dechoux commented on MRUNIT-120:
-----------------------------------------
Is this one still relevant after the patch on MRUNIT-119?
Counters shouldn't have that many names. (It is even enforced to be under 120 different name values by default, now, I think).
So they can indeed change due to refactoring but this case is supported MRUNIT-119.
I am only mentioning it in order to not forget that MRUNIT-119 was created around the same time. I don't have a definitive position on that subject.
> Counter tests should support wildcard/regex names
> -------------------------------------------------
>
> Key: MRUNIT-120
> URL: https://issues.apache.org/jira/browse/MRUNIT-120
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Dave Beech
> Priority: Minor
>
> From Bertrand Dechoux via user mailing list.
> "The issue is that I might no know the name of the counters because they are dynamic. Even the group name is kind of dynamic because for warning counters, I use the class name and so it might change after refactoring."
> Currently it is difficult to test counters with dynamically generated names. Also, as Bertrand mentioned in the email, hardcoding names can make tests brittle and break after code refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-120) Counter tests should support
wildcard/regex names
Posted by "Dave Beech (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425602#comment-13425602 ]
Dave Beech commented on MRUNIT-120:
-----------------------------------
Probably not. I still think it might be quite a nice thing to add, but not important enough that I actually want to spend any time working on it! Unless anyone objects, I'll close this and mark it as "won't fix" or "later".
> Counter tests should support wildcard/regex names
> -------------------------------------------------
>
> Key: MRUNIT-120
> URL: https://issues.apache.org/jira/browse/MRUNIT-120
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Dave Beech
> Priority: Minor
>
> From Bertrand Dechoux via user mailing list.
> "The issue is that I might no know the name of the counters because they are dynamic. Even the group name is kind of dynamic because for warning counters, I use the class name and so it might change after refactoring."
> Currently it is difficult to test counters with dynamically generated names. Also, as Bertrand mentioned in the email, hardcoding names can make tests brittle and break after code refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira