You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 03:57:30 UTC

[GitHub] [arrow-rs] viirya commented on a change in pull request #1367: More idiomatic primitive array creation

viirya commented on a change in pull request #1367:
URL: https://github.com/apache/arrow-rs/pull/1367#discussion_r816430830



##########
File path: arrow/src/array/array_primitive.rs
##########
@@ -329,8 +330,53 @@ impl<'a, T: ArrowPrimitiveType> PrimitiveArray<T> {
     }
 }
 
-impl<T: ArrowPrimitiveType, Ptr: Borrow<Option<<T as ArrowPrimitiveType>::Native>>>
-    FromIterator<Ptr> for PrimitiveArray<T>
+#[derive(Debug)]
+pub struct ArrowPrimitiveTypeNative<T: ArrowPrimitiveType> {

Review comment:
       If people want to use their types to create arrays from an iterator, they need to implement `From` for `ArrowPrimitiveTypeNative`. So I guess we need it to be `pub`? I will document it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org