You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/12 17:45:57 UTC

[GitHub] [incubator-superset] bkyryliuk opened a new pull request #8219: [WIP] Build better support for schema permissions

bkyryliuk opened a new pull request #8219: [WIP] Build better support for schema permissions
URL: https://github.com/apache/incubator-superset/pull/8219
 
 
   NOTE: WIP on testing on the staging and prod @ dropbox
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Implementing my old TODO :) This PR implements better support for the schema access permissions, e.g. enables users to use sql lab and view slices, tables in the view models.
   In order to achieve that schema_perm will be serialized in DB along side with perm and will be updated on the model changes. It will allows us to continue using filters in the model views.
   
   Note: moved changes from https://github.com/apache/incubator-superset/pull/8189 to this diff to have more holistic view on the approach.
   ### TEST PLAN
   * added unit tests
   * tested locally 
   [] WIP on testing on the dropbox staging & production instance
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue:
   - [ ] Changes UI
   - [X] Requires DB Migration.
   - [X] Confirm DB Migration upgrade and downgrade tested. Note: downgrade doesn't work on sqlite
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   * @mistercrunch 
   * @dpgaspar 
   * @john-bodley 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org