You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashish Singh <as...@cloudera.com> on 2014/05/27 20:38:26 UTC
Re: Review Request 21846: Avoid using same table in two different tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated May 27, 2014, 6:38 p.m.)
Review request for hive and Szehon Ho.
Changes
-------
Avoid using same table in two different tests
Summary (updated)
-----------------
Avoid using same table in two different tests
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description (updated)
-------
Partitions not inheriting table permissions after alter rename partition
Avoid using same table in two different tests
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java ee61350ab1d32db96a234f6444836f76e23f3251
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java 4f566d2a2999eecea7018836505208ae80662e97
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b01043b3520211643847c00b17b328ad2b9c0
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b427e7fa64780fdf0a580f28135d6a4ff8d
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
> On June 3, 2014, 5:57 a.m., Szehon Ho wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 208
> > <https://reviews.apache.org/r/21846/diff/6/?file=602405#file602405line208>
> >
> > I missed this earlier, can we just return the value returned from here instead of having an extra returns after this line?
Done!
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/#review44602
-----------------------------------------------------------
On June 3, 2014, 9:10 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21846/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 9:10 p.m.)
>
>
> Review request for hive and Szehon Ho.
>
>
> Bugs: HIVE-7117
> https://issues.apache.org/jira/browse/HIVE-7117
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
>
>
> Inherit permissions from parent while renaming directories or files under hive
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java ea52537
>
> Diff: https://reviews.apache.org/r/21846/diff/
>
>
> Testing
> -------
>
> Tested with itests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/#review44602
-----------------------------------------------------------
Thanks for rebasing! One minor suggestion (apologies for not seeing it earlier). Other than that, looks good
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java
<https://reviews.apache.org/r/21846/#comment79023>
I missed this earlier, can we just return the value returned from here instead of having an extra returns after this line?
- Szehon Ho
On June 3, 2014, 3:38 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21846/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 3:38 a.m.)
>
>
> Review request for hive and Szehon Ho.
>
>
> Bugs: HIVE-7117
> https://issues.apache.org/jira/browse/HIVE-7117
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
>
>
> Inherit permissions from parent while renaming directories or files under hive
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
>
> Diff: https://reviews.apache.org/r/21846/diff/
>
>
> Testing
> -------
>
> Tested with itests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated June 3, 2014, 9:16 p.m.)
Review request for hive and Szehon Ho.
Changes
-------
Correcting patch. Ignore previous patch.
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description
-------
Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
Inherit permissions from parent while renaming directories or files under hive
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated June 3, 2014, 9:10 p.m.)
Review request for hive and Szehon Ho.
Changes
-------
Addressed review comments.
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description
-------
Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
Inherit permissions from parent while renaming directories or files under hive
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java ea52537
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
> On June 3, 2014, 2:37 p.m., Swarnim Kulkarni wrote:
> > common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 591
> > <https://reviews.apache.org/r/21846/diff/2/?file=589240#file589240line591>
> >
> > Like I said its pretty minor but in my opinion its easy to miss the intention of a method when someone has to look through half a dozen arguments to understand that. A simple method name like "renameWithPerms" make things more clear for a first time consumer.
OK, changed to "renameWithPerms".
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/#review44626
-----------------------------------------------------------
On June 3, 2014, 9:10 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21846/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 9:10 p.m.)
>
>
> Review request for hive and Szehon Ho.
>
>
> Bugs: HIVE-7117
> https://issues.apache.org/jira/browse/HIVE-7117
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
>
>
> Inherit permissions from parent while renaming directories or files under hive
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java ea52537
>
> Diff: https://reviews.apache.org/r/21846/diff/
>
>
> Testing
> -------
>
> Tested with itests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Swarnim Kulkarni <ku...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/#review44626
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/FileUtils.java
<https://reviews.apache.org/r/21846/#comment79042>
Like I said its pretty minor but in my opinion its easy to miss the intention of a method when someone has to look through half a dozen arguments to understand that. A simple method name like "renameWithPerms" make things more clear for a first time consumer.
- Swarnim Kulkarni
On June 3, 2014, 3:38 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21846/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 3:38 a.m.)
>
>
> Review request for hive and Szehon Ho.
>
>
> Bugs: HIVE-7117
> https://issues.apache.org/jira/browse/HIVE-7117
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
>
>
> Inherit permissions from parent while renaming directories or files under hive
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
>
> Diff: https://reviews.apache.org/r/21846/diff/
>
>
> Testing
> -------
>
> Tested with itests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated June 3, 2014, 3:38 a.m.)
Review request for hive and Szehon Ho.
Changes
-------
rbt post messes the subject of JIRA.
Summary (updated)
-----------------
HIVE-7117: Partitions not inheriting table permissions after alter rename partition
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description
-------
Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
Inherit permissions from parent while renaming directories or files under hive
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh
Re: Review Request 21846: Correct FolderPermissionsBase test and change
rename method to inherit permissions and/or extended ACLs
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated June 3, 2014, 3:34 a.m.)
Review request for hive and Szehon Ho.
Changes
-------
Rebased.
Summary (updated)
-----------------
Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description (updated)
-------
Correct FolderPermissionsBase test and change rename method to inherit permissions and/or extended ACLs
Inherit permissions from parent while renaming directories or files under hive
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java 57fe4cf
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b010
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated May 28, 2014, 10:10 p.m.)
Review request for hive and Szehon Ho.
Changes
-------
Change table name to have all lowercase letters. Looks like table name is toLower'ed by hive while creating file
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description (updated)
-------
Change table name to have all lowercase letters. Looks like table name is toLower'ed by hive while creating file
Avoid using same table in two different tests
HIVE-7117: Partitions not inheriting table permissions after alter rename partition
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java ee61350ab1d32db96a234f6444836f76e23f3251
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java 4f566d2a2999eecea7018836505208ae80662e97
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b01043b3520211643847c00b17b328ad2b9c0
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b427e7fa64780fdf0a580f28135d6a4ff8d
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh
Re: Review Request 21846: HIVE-7117: Partitions not inheriting table
permissions after alter rename partition
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21846/
-----------------------------------------------------------
(Updated May 27, 2014, 6:38 p.m.)
Review request for hive and Szehon Ho.
Summary (updated)
-----------------
HIVE-7117: Partitions not inheriting table permissions after alter rename partition
Bugs: HIVE-7117
https://issues.apache.org/jira/browse/HIVE-7117
Repository: hive-git
Description
-------
Partitions not inheriting table permissions after alter rename partition
Avoid using same table in two different tests
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java ee61350ab1d32db96a234f6444836f76e23f3251
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java 4f566d2a2999eecea7018836505208ae80662e97
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 221b01043b3520211643847c00b17b328ad2b9c0
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b427e7fa64780fdf0a580f28135d6a4ff8d
Diff: https://reviews.apache.org/r/21846/diff/
Testing
-------
Tested with itests.
Thanks,
Ashish Singh