You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/19 16:14:34 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
zuzana-vej opened a new issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329
In the past when user selects schema and table name, SQL Lab displays list of columns on the left side and switches automatically to "Preview tab", so that the user can preview the data immediately. After the recent changes in SQL Lab, the default tab stays at "Results" (which are SQL Lab query results) so user needs to make an extra click to switch to the preview tab to preview their data.
### Expected results
Tab automatically switches to "Preview: table-name"
### Actual results
Tab remains as "Results"
#### Screenshots
1. user selects schema & table
2. Default tab should change to "Preview: table-name" (this was past behavior)
#### How to reproduce the bug
1. Go to SQL Lab
2. Select schema in the picker on left side
3. Select table name
4. List of columns loads properly; the tab stays at "Results" instead of switching to "Preview" so that user can preview data
### Environment
(please complete the following information):
- superset version: master
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-717374861
Yeah. No problem. I'll close this and if necessary reopen. Thanks for checking @kgabryje
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-717329545
@zuzana-vej I'm sorry, but I cannot reproduce it 🙁 Does anybody else still experience this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-714618738
Yes latest master, just synced it yesterday. Using Chrome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-714153123
I am still seeing the issue. Switching tabs works. But in the past, when user selects a table name on left side from the schema, it automatically switched to the tab with the preview. Currently the tab shows up, but user needs to manually switch.
Is this new behavior as designed or a bug?
Image 1: Searching for the table I selected
<img width="741" alt="Screen Shot 2020-10-21 at 6 32 02 PM" src="https://user-images.githubusercontent.com/61221714/96807670-04d11700-13cc-11eb-994b-1a4a402431e0.png">
Image 2: See the data preview isn't default tab
<img width="757" alt="Screen Shot 2020-10-21 at 6 32 11 PM" src="https://user-images.githubusercontent.com/61221714/96807664-026ebd00-13cc-11eb-9613-804bf98d845f.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej edited a comment on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-717374861
Yeah. No problem. I'll close this and if necessary reopen. Thanks for checking @kgabryje
EDIT: confirmed works as expected thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712955047
@kgabryje thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712567560
@lilykuang Lily, I believe you have been working on this area. please take a look at this issue🙏
@willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc closed issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-714333323
@zuzana-vej Are you sure you're testing it on the latest master? For me it was exactly like you expect (see gif).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712703430
I'll check it out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712575359
@junlincc this could be related to recent `antd` `<Tab/>` work by @kgabryje (?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-714333323
@zuzana-vej Are you sure you're testing it on the latest master? For me it works exactly like you expect (see gif).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712274727
Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.82. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-713148695
Fix merged!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712767760
@zuzana-vej @mistercrunch Here's a fix: https://github.com/apache/incubator-superset/pull/11343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej closed issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc removed a comment on issue #11329: SQL should display "query preview" by default when user selects schema & table (past behavior)
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on issue #11329:
URL: https://github.com/apache/incubator-superset/issues/11329#issuecomment-712567560
@lilykuang Lily, I believe you have been working on this area. please take a look at this issue🙏
@willbarrett
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org