You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/30 13:22:49 UTC

[GitHub] [kafka] urbandan opened a new pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

urbandan opened a new pull request #8957:
URL: https://github.com/apache/kafka/pull/8957


   Implements KIP-308
   
   Changes:
   - Added kafka-get-offsets.sh script
   - Removed deprecated max-wait-ms and offsets arguments
   - Updated tool to query all topic-partitions by default
   - Updated topic argument to support patterns
   - Added topic-partitions argument to support a list of topic-partition patterns
   - Added exclude-internal-topics to support filtering internal topics
   
   Testing done: added new ducktape tests for the tool.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] urbandan commented on pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

Posted by GitBox <gi...@apache.org>.
urbandan commented on pull request #8957:
URL: https://github.com/apache/kafka/pull/8957#issuecomment-661892966


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] omkreddy commented on pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

Posted by GitBox <gi...@apache.org>.
omkreddy commented on pull request #8957:
URL: https://github.com/apache/kafka/pull/8957#issuecomment-651811192


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] huxihx commented on pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

Posted by GitBox <gi...@apache.org>.
huxihx commented on pull request #8957:
URL: https://github.com/apache/kafka/pull/8957#issuecomment-654083327


   I do not see the counterpart for Windows. We should add `kafka-get-offsets.bat` as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] urbandan commented on pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

Posted by GitBox <gi...@apache.org>.
urbandan commented on pull request #8957:
URL: https://github.com/apache/kafka/pull/8957#issuecomment-659973853


   @huxihx thanks for catching that, added the .bat.
   
   Based on the discussion thread, also updated the usage to mention that only authorized topics are listed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] urbandan closed pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

Posted by GitBox <gi...@apache.org>.
urbandan closed pull request #8957:
URL: https://github.com/apache/kafka/pull/8957


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org