[jira] [Commented] (PHOENIX-4368) Fix MapReduce related classes

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253746#comment-16253746 ] 

Josh Elser commented on PHOENIX-4368:
-------------------------------------

{noformat}
-        final Algorithm defaultCompression = AbstractHFileWriter
+        final Algorithm defaultCompression = HFileWriterImpl
             .compressionByName(defaultCompressionStr);
{noformat}

This looks like something that should be lifted to {{HFile.Writer}} (with the Java8 default method fanciness) or moved to a utility class. As it stands, this is marked as private and we shouldn't be using it in Phoenix. Fine for now, but this is something we should follow up on HBase. Please create a JIRA for HBase or let me know and I can create one :)

+1 otherwise. Thanks for the update on the Commons-Cli PosixParser->DefaultParser too!

> Fix MapReduce related classes
> -----------------------------
>
>                 Key: PHOENIX-4368
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4368
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Josh Elser
>            Assignee: Ankit Singhal
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-4368.patch
>
>
> A list of what I'm seeing failing right now:
> * PhoenixIndexPartialBuildMapper.java
> * MultiHfileOutputFormat.java
> * FormatToKeyValueReducer.java
> * PhoenixMRJobCallable.java
> * PhoenixInputFormat.java
> * IndexTool.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)