You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@vcl.apache.org by ar...@apache.org on 2017/07/21 17:53:20 UTC

svn commit: r1802628 - /vcl/trunk/managementnode/lib/VCL/Module/OS/Linux.pm

Author: arkurth
Date: Fri Jul 21 17:53:20 2017
New Revision: 1802628

URL: http://svn.apache.org/viewvc?rev=1802628&view=rev
Log:
VCL-1055
Added check in Linux.pm::set_static_default_gateway to ensure value returned from get_public_default_gateway() is defined before comparing it to avoid uninitialized warnings in vcld.log.

Modified:
    vcl/trunk/managementnode/lib/VCL/Module/OS/Linux.pm

Modified: vcl/trunk/managementnode/lib/VCL/Module/OS/Linux.pm
URL: http://svn.apache.org/viewvc/vcl/trunk/managementnode/lib/VCL/Module/OS/Linux.pm?rev=1802628&r1=1802627&r2=1802628&view=diff
==============================================================================
--- vcl/trunk/managementnode/lib/VCL/Module/OS/Linux.pm (original)
+++ vcl/trunk/managementnode/lib/VCL/Module/OS/Linux.pm Fri Jul 21 17:53:20 2017
@@ -1085,7 +1085,7 @@ sub restart_network_interface {
 		return;
 	}
 	else {
-		notify($ERRORS{'DEBUG'}, 0, "restarted $interface_name interface on $computer_name");
+		notify($ERRORS{'DEBUG'}, 0, "restarted $interface_name interface on $computer_name, output:\n" . join("\n", @$output));
 	}
 	
 	return 1;
@@ -1156,7 +1156,7 @@ sub set_static_default_gateway {
 	}
 	
 	my $current_default_gateway = $self->get_public_default_gateway();
-	if ($current_default_gateway eq $default_gateway) {
+	if ($current_default_gateway && $current_default_gateway eq $default_gateway) {
 		notify($ERRORS{'OK'}, 0, "default gateway on $computer_name is already set to $current_default_gateway");
 		return 1;
 	}