You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2025/09/09 16:52:44 UTC

Re: [PR] [SPARK-53356][PYTHON][DOCS] Small improvements to python data source docs [spark]

allisonwang-db commented on code in PR #52101:
URL: https://github.com/apache/spark/pull/52101#discussion_r2334223808


##########
python/docs/source/tutorial/sql/python_data_source.rst:
##########
@@ -327,7 +355,7 @@ This is a streaming data writer that write the metadata information of each micr
                cnt += 1
            return SimpleCommitMessage(partition_id=partition_id, count=cnt)
 
-       def commit(self, messages, batchId) -> None:
+       def commit(self, messages: List[Optional[WriterCommitMessage]], batchId: int) -> None:

Review Comment:
   nit: This should be `List[Optional[SimpleCommitMessage]]`



##########
python/docs/source/tutorial/sql/python_data_source.rst:
##########
@@ -336,7 +364,7 @@ This is a streaming data writer that write the metadata information of each micr
            with open(os.path.join(self.path, f"{batchId}.json"), "a") as file:
                file.write(json.dumps(status) + "\n")
 
-       def abort(self, messages, batchId) -> None:
+       def abort(self, messages: List[Optional[WriterCommitMessage]], batchId: int) -> None:

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org