You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/20 13:22:07 UTC

[GitHub] [incubator-seatunnel] PrajwalBorkar opened a new pull request, #2226: [Doc]: updated link in Seatunnel website

PrajwalBorkar opened a new pull request, #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
    Fixes #2222
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1191026814

   > Maybe we can directly using content `/category/source` and `/category/source` to our concept. And then add some tricks in our dead link checker, just like
   > 
   > https://github.com/apache/incubator-seatunnel/blob/a505d50f6c7151a612e974bba28927d5faac021e/.dlc.json#L19
   > 
   > to skip those specific rule
   
   The reason CI thinks `/docs/category/*` is not a dead link it is because we added some ignore pattern in dead link checker


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1191011798

   will make a quick test myself


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1191003255

   @zhongjiajie Hi, Do we have other way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] PrajwalBorkar commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
PrajwalBorkar commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1195479670

   Yeah, you can use my branch to commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1191011534

   Maybe we can directly using content `/category/source` and `/category/source` to our concept. And then add some tricks in our dead link checker, just like https://github.com/apache/incubator-seatunnel/blob/a505d50f6c7151a612e974bba28927d5faac021e/.dlc.json#L19 to skip those specific rule


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] PrajwalBorkar commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
PrajwalBorkar commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1231932977

   I think @zhongjiajie is working on this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1230390046

   @PrajwalBorkar Hi, we had update seatunnel website path for transform//source/sink. So you can update link easily, can you go on work for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1191025954

   Hi @PrajwalBorkar I make a quick test and it work correctly. You should:
   
   0. Change sidebar https://github.com/apache/incubator-seatunnel/blob/62ca0759155a5521c2996a0fe12441a264f6a10e/docs/sidebars.js#L184-L196 and make `transform` some as source or sink(you can find in the `sidebar.js` with keyword `type: 'generated-index'` to see how to create it), which supported the category page link https://seatunnel.apache.org/docs/category/source.
   1. Make some change in concept file, change `../connector/source` to `/docs/category/source`, `../transform` to `/docs/category/transform`, and `../connector/sink` to `/docs/category/sink`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1195378953

   > > Hi @PrajwalBorkar I make a quick test and it work correctly. You should:
   > > 
   > > 0. Change sidebar https://github.com/apache/incubator-seatunnel/blob/62ca0759155a5521c2996a0fe12441a264f6a10e/docs/sidebars.js#L184-L196
   > >    
   > >    and make `transform` some as source or sink(you can find in the `sidebar.js` with keyword `type: 'generated-index'` to see how to create it), which supported the category page link https://seatunnel.apache.org/docs/category/source.
   > > 1. Make some change in concept file, change `../connector/source` to `/docs/category/source`, `../transform` to `/docs/category/transform`, and `../connector/sink` to `/docs/category/sink`.
   > 
   > So I have to change `transform` to
   > 
   > https://github.com/apache/incubator-seatunnel/blob/62ca0759155a5521c2996a0fe12441a264f6a10e/docs/sidebars.js#L146-L163
   > 
   > .Im not able to understand how to make changes here.
   
   @PrajwalBorkar  do you mind I append a new commit to your branch? If not I will add a new commit to implement it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] PrajwalBorkar commented on pull request #2226: [Doc]: updated link in Seatunnel website

Posted by GitBox <gi...@apache.org>.
PrajwalBorkar commented on PR #2226:
URL: https://github.com/apache/incubator-seatunnel/pull/2226#issuecomment-1191760159

   > Hi @PrajwalBorkar I make a quick test and it work correctly. You should:
   > 
   > 0. Change sidebar https://github.com/apache/incubator-seatunnel/blob/62ca0759155a5521c2996a0fe12441a264f6a10e/docs/sidebars.js#L184-L196
   >     and make `transform` some as source or sink(you can find in the `sidebar.js` with keyword `type: 'generated-index'` to see how to create it), which supported the category page link https://seatunnel.apache.org/docs/category/source.
   > 1. Make some change in concept file, change `../connector/source` to `/docs/category/source`, `../transform` to `/docs/category/transform`, and `../connector/sink` to `/docs/category/sink`.
   
   So I have to change `transform` to https://github.com/apache/incubator-seatunnel/blob/62ca0759155a5521c2996a0fe12441a264f6a10e/docs/sidebars.js#L146-L163  .Im not able to understand how to make changes here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org