[GitHub] leventov commented on issue #7075: [PROPOSAL] 7057 Add a Configurable Event Throttling Policy to Asynchronous Emitters

[GitBox <gi...@apache.org>]

leventov commented on issue #7075: [PROPOSAL] 7057 Add a Configurable Event Throttling Policy to Asynchronous Emitters
URL: https://github.com/apache/incubator-druid/issues/7075#issuecomment-463786310
 
 
   `AmbariMetricsEmitter` doesn't need to extend `AbstractTimelineMetricsSink`. This is actually a bad use of inheritance instead of composition. Its internal `ConsumerRunnable` can extend `AbstractTimelineMetricsSink`, or a separate private class.
   
   I'm not sure we should introduce configurations before somebody actually needs them. One reason is that it's hard to change `HttpPostEmitter` to support policies different from "drop oldest batch", that is also not exactly equivalent to queue-based emitters's "drop oldest events". I think we may start with just dropping oldest events in queue-based emitters and reporting, for example, one 1000th drop (but making sure that we report the very first one).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org