You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2023/08/23 01:47:26 UTC

[GitHub] [beam] bvolpato opened a new pull request, #28116: Bump classgraph version to 4.8.162

bvolpato opened a new pull request, #28116:
URL: https://github.com/apache/beam/pull/28116

   I'm helping to investigate a scenario where classpath scanning is taking a lot of time (>10 minutes), and from the logs the only operation between the lines below seem to be classgraph.
   
   > INFO 2023-08-22T01:36:26Z [main] INFO org.apache.beam.runners.dataflow.options.DataflowPipelineOptions$StagingLocationFactory - No stagingLocation provided, falling back to gcpTempLocation
   > INFO 2023-08-22T01:49:04Z [main] INFO org.apache.beam.runners.dataflow.DataflowRunner - PipelineOptions.filesToStage was not specified. Defaulting to files from the classpath: will stage 1 files. Enable logging at DEBUG level to see which files will be staged.
   
   
   Unfortunately I couldn't reproduce locally, but debugging or raising bugs is not likely to go anywhere because the version is over 2 years old, and missing several improvements https://github.com/classgraph/classgraph/compare/classgraph-4.8.104...classgraph-4.8.162.
   
   So bumping it as a mean to reduce tech debt.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1689171109

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1689233923

   Run Go PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #28116: Bump classgraph version to 4.8.162

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28116:
URL: https://github.com/apache/beam/pull/28116#discussion_r1319811100


##########
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/resources/ClasspathScanningResourcesDetectorTest.java:
##########
@@ -120,7 +120,7 @@ public void shouldDetectClassPathResourceFromJavaClassPathEnvVariable() throws I
 
   @Test
   public void shouldNotDetectClassPathResourceThatIsNotAFile() throws Exception {
-    String url = "http://www.google.com/all-the-secrets.jar";
+    String url = "http://www.example.com/all-the-secrets.jar";

Review Comment:
   Why did we need this change? Was the test failing without the change or was it just to make it more generic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1706508152

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1689233950

   Run Python_Runners PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on a diff in pull request #28116: Bump classgraph version to 4.8.162

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #28116:
URL: https://github.com/apache/beam/pull/28116#discussion_r1319838762


##########
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/resources/ClasspathScanningResourcesDetectorTest.java:
##########
@@ -120,7 +120,7 @@ public void shouldDetectClassPathResourceFromJavaClassPathEnvVariable() throws I
 
   @Test
   public void shouldNotDetectClassPathResourceThatIsNotAFile() throws Exception {
-    String url = "http://www.google.com/all-the-secrets.jar";
+    String url = "http://www.example.com/all-the-secrets.jar";

Review Comment:
   Cool - that makes sense, thanks. Just wanted to make sure we weren't changing for a failing test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm merged pull request #28116: Bump classgraph version to 4.8.162

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #28116:
URL: https://github.com/apache/beam/pull/28116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1696427266

   Run Java_PVR_Flink_Batch PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] chamikaramj commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1696425792

   LGTM. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1711575414

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] codecov[bot] commented on pull request #28116: Bump classgraph version to 4.8.162

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28116:
URL: https://github.com/apache/beam/pull/28116#issuecomment-1689152588

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28116?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#28116](https://app.codecov.io/gh/apache/beam/pull/28116?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1ef4b51) into [master](https://app.codecov.io/gh/apache/beam/commit/c8afd9c2580b5fc20d9c14e50bb54be7a2b328d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c8afd9c) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #28116   +/-   ##
   =======================================
     Coverage   72.30%   72.30%           
   =======================================
     Files         678      678           
     Lines       99793    99793           
   =======================================
   + Hits        72153    72154    +1     
   + Misses      26078    26077    -1     
     Partials     1562     1562           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/28116/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/28116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.85% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 5 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28116/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on a diff in pull request #28116: Bump classgraph version to 4.8.162

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #28116:
URL: https://github.com/apache/beam/pull/28116#discussion_r1319829087


##########
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/resources/ClasspathScanningResourcesDetectorTest.java:
##########
@@ -120,7 +120,7 @@ public void shouldDetectClassPathResourceFromJavaClassPathEnvVariable() throws I
 
   @Test
   public void shouldNotDetectClassPathResourceThatIsNotAFile() throws Exception {
-    String url = "http://www.google.com/all-the-secrets.jar";
+    String url = "http://www.example.com/all-the-secrets.jar";

Review Comment:
   No failures -- just to make it more generic.
   
   Not hard to think that bots / crawler can try to follow that link.
   
   http://www.example.com/ is an IANA domain serves this purpose:
   
   ![image](https://github.com/apache/beam/assets/3207647/76cf0221-d598-42fb-bda4-ecff950cf876)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org