You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@empire-db.apache.org by Rainer Döbele <do...@esteam.de> on 2009/03/25 21:35:32 UTC
Review of release assembly
Hi Francis,
again I ran out of time and only had the chance to take a quick look at the empire-db-2.0.5-SNAPSHOT.
These are my first findings:
1. The name of the archive must be "apache-empire-db-2.0.5-incubating.zip" (or .tar.gz respectively)
2. The root directory must contain the README.TXT with the Apache disclaimer, the LICENSE.TXT containing the Apache License and the NOTICE.TXT. If we decide to provide the hsqldb.jar we would also need to supply the LICENSE-HSQLDB.txt. Without those files supplied in the root directory we will not be able to get the approval of the community. I would appreciate to also have the tutorial.pdf there. Don't know where to supply the changelog (expecially if we distribute core and struts2-ext together)
3. I was surprised to find that the size of the archive was 19,3 MB. The reason was soon discovered: The file empire-db-example-struts2-cxf-2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I don't think it makes sense to include the compiled examples. I would prefer only to provide the empire-db-2.0.5.jar and the empire-db-struts2-2.0.5.jar (without the "SNAPSHOT").
4. I was unable to find the javadoc. Is Javadoc generation missing in the maven build?
5. Due to the missing dependencies and project files it is virtually impossible for someone who is not familiar with Maven to run any of the sample applications. Shouldn't we give a clue how to best set things up with Maven and maybe even how to live without?
Question: Can you fix issues 1 - 4 easily?
Thanks and best regards
Rainer
Re: Review of release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
I'll have a look at these issues when my pc is up and running again
(I'm upgrading my hd to a ssd)
But I think all issues can be fixed. Do we realy need to include
javadoc as those are available in the maven repo an can be linked to
from the site?
On Wed, Mar 25, 2009 at 9:35 PM, Rainer Döbele <do...@esteam.de> wrote:
> Hi Francis,
>
> again I ran out of time and only had the chance to take a quick look at the empire-db-2.0.5-SNAPSHOT.
> These are my first findings:
>
> 1. The name of the archive must be "apache-empire-db-2.0.5-incubating.zip" (or .tar.gz respectively)
>
> 2. The root directory must contain the README.TXT with the Apache disclaimer, the LICENSE.TXT containing the Apache License and the NOTICE.TXT. If we decide to provide the hsqldb.jar we would also need to supply the LICENSE-HSQLDB.txt. Without those files supplied in the root directory we will not be able to get the approval of the community. I would appreciate to also have the tutorial.pdf there. Don't know where to supply the changelog (expecially if we distribute core and struts2-ext together)
>
> 3. I was surprised to find that the size of the archive was 19,3 MB. The reason was soon discovered: The file empire-db-example-struts2-cxf-2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I don't think it makes sense to include the compiled examples. I would prefer only to provide the empire-db-2.0.5.jar and the empire-db-struts2-2.0.5.jar (without the "SNAPSHOT").
>
> 4. I was unable to find the javadoc. Is Javadoc generation missing in the maven build?
>
> 5. Due to the missing dependencies and project files it is virtually impossible for someone who is not familiar with Maven to run any of the sample applications. Shouldn't we give a clue how to best set things up with Maven and maybe even how to live without?
>
>
> Question: Can you fix issues 1 - 4 easily?
>
> Thanks and best regards
>
> Rainer
>
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: Review of release assembly
Posted by Thomas Fischer <fi...@seitenbau.net>.
> Concering the SNAPSHOT extension on our jars I have a question
> (probably best answered by the mentors): The jars are in the archive
> that we put up for voting. If the vote succeeds, is it acceptable to
> remove the extension or would it be better to remove the extension
> beforehand? (Personally I would do the latter).
I am more comfortable with the second option, but I'd accept the first
method.
Regards,
Thomas
Re: Building the release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
Well I've been quite busy lately but Tuesday evening I will try to get
the remaining fixes done.
Do we want a rc1, rc2, ... path or do we go directly to a full release?
Francis
On Mon, Apr 6, 2009 at 10:55 AM, Rainer Döbele <do...@esteam.de> wrote:
> Hi Francis,
>
> regarding the naming of the projects and jars, I have rethought and decided that I leave the naming up to you.
> The important thing is that we put together an assembly that contains everything that is required and that makes it easy for potential users to get started with Empire-db.
>
> BTW: This month we are scheduled for our normal PMC board report in which we have to give information about the progress of the project. It'd be cool if we could say that we have a potential release candiate. And as I said I expect a lot more feedback once we have a candiate to discuss about.
>
> Please let me know how you get along with assembly build to accomodate the changes we planned on Sunday 29th.
>
> Best regards,
> Rainer
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: Building the release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
Rainer,
I tried to fix the remaining issues (eg using release.sh now builds a
distribution including javadoc) but there might still be some issues
left.
Let me know what else needs to be done.
On Mon, Apr 6, 2009 at 10:55 AM, Rainer Döbele <do...@esteam.de> wrote:
> Hi Francis,
>
> regarding the naming of the projects and jars, I have rethought and decided that I leave the naming up to you.
> The important thing is that we put together an assembly that contains everything that is required and that makes it easy for potential users to get started with Empire-db.
>
> BTW: This month we are scheduled for our normal PMC board report in which we have to give information about the progress of the project. It'd be cool if we could say that we have a potential release candiate. And as I said I expect a lot more feedback once we have a candiate to discuss about.
>
> Please let me know how you get along with assembly build to accomodate the changes we planned on Sunday 29th.
>
> Best regards,
> Rainer
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Building the release assembly
Posted by Rainer Döbele <do...@esteam.de>.
Hi Francis,
regarding the naming of the projects and jars, I have rethought and decided that I leave the naming up to you.
The important thing is that we put together an assembly that contains everything that is required and that makes it easy for potential users to get started with Empire-db.
BTW: This month we are scheduled for our normal PMC board report in which we have to give information about the progress of the project. It'd be cool if we could say that we have a potential release candiate. And as I said I expect a lot more feedback once we have a candiate to discuss about.
Please let me know how you get along with assembly build to accomodate the changes we planned on Sunday 29th.
Best regards,
Rainer
re: Building the release assembly
Posted by Rainer Döbele <do...@esteam.de>.
Hi Francis,
agreed that we should not make the release in a rush. If you need more time, no problem.
But I think we're feature complete and we now need something that we can discuss about.
You will find that people are much more willing to give their opinion, once there is a release candiate up for voting.
That's the main reason I want to go ahead so quickly.
It is very likely that people will suggest changes then.
more comments see below:
> Re: Building the release assembly
> > But I have another issue concering the naming of the empire-struts2-ext:
> > I have delibertately chosen the name not to include the -db since there is no database functionaltiy in there. The package namespace reflects this as well. Hence the name of the jar should be empire-struts2-ext-xxx.jar (with xxx standing for the version string).
> > The same applies to the Maven artifact id which should be empire-struts2-ext.
> > Ideally this should also apply to the project name but this would probably be too much hassle to change now.
>
> I don't agree here, the project is empire-db, or not? Otherwise I
> would call everyting empire-...
> The struts-2 extensions are the extensions for using struts2 with
> empire-db, what does empire without -db stand for?
Please look at all the package namespace names in both the empire-db and the empire-struts2-ext projects.
They should give you a clue what the intention was.
All I am saying is that the jar names should reflect this.
There is always room for extentions above the db level.
I know it's a matter of taste, but I rather want to stick roughly to what we did in our previous release.
> > Also the version string should only be <version>2.0.5-SNAPSHOT</version> (personally I would even remove the SNAPSHOT). I could change this myself, but they are your files and I better ask beforehand.
> > Concering the naming I would suggest to stick to the naming of our previous release (see http://incubator.apache.org/empire-db/downloads/downloads.htm).
>
> SNAPSHOT is a maven convention, there is no way around it. As release
> won't be called SNAPSHOT I don't see no problem. SNAPSHOT is the maven
> way to indicate a version between two releases.
Sorry if you misunderstood me here. I have no problem with the SNAPSHOT, apart from the thing that we discussed last time, that we'd have to rebuild the assembly once it has been accepted by the incubator PMC. But it is not necessary, that the jars contain the incubating. So e.g. empire-db-2.0.5-SNAPSHOT.jar is fine for me. But the incubating must be part of the release assembly name.
> I'm still for the easy (kiss) solution that most apache projects use.
> Have the project name definded (empire or empire-db), all modules have
> the same version and are called [empire name]-[module].
>
Yes, I am a big KISS fan too, except that I didn't like their make-up (joking).
I like to phrase to keep it as simple as possible but as complex as necessary.
> >
> > Please let me know, when you have changed the assembly generation so I can check it an possibly put it up for voting.
> > I think we both want to get this release out asap.
>
> I'd like to know what other ppl are thinking about this. It's just
> that preparing new releases should not be a hassle. I'll make some
> time to apply the changes to the assembly.
>
> >
> > Regards
> > Rainer
> >
> >
Re: Building the release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
> But I have another issue concering the naming of the empire-struts2-ext:
> I have delibertately chosen the name not to include the -db since there is no database functionaltiy in there. The package namespace reflects this as well. Hence the name of the jar should be empire-struts2-ext-xxx.jar (with xxx standing for the version string).
> The same applies to the Maven artifact id which should be empire-struts2-ext.
> Ideally this should also apply to the project name but this would probably be too much hassle to change now.
I don't agree here, the project is empire-db, or not? Otherwise I
would call everyting empire-...
The struts-2 extensions are the extensions for using struts2 with
empire-db, what does empire without -db stand for?
> Also the version string should only be <version>2.0.5-SNAPSHOT</version> (personally I would even remove the SNAPSHOT). I could change this myself, but they are your files and I better ask beforehand.
> Concering the naming I would suggest to stick to the naming of our previous release (see http://incubator.apache.org/empire-db/downloads/downloads.htm).
SNAPSHOT is a maven convention, there is no way around it. As release
won't be called SNAPSHOT I don't see no problem. SNAPSHOT is the maven
way to indicate a version between two releases.
I'm still for the easy (kiss) solution that most apache projects use.
Have the project name definded (empire or empire-db), all modules have
the same version and are called [empire name]-[module].
>
> Please let me know, when you have changed the assembly generation so I can check it an possibly put it up for voting.
> I think we both want to get this release out asap.
I'd like to know what other ppl are thinking about this. It's just
that preparing new releases should not be a hassle. I'll make some
time to apply the changes to the assembly.
>
> Regards
> Rainer
>
>
> -----Ursprüngliche Nachricht-----
> Von: Rainer Döbele [mailto:doebele@esteam.de]
> Gesendet: So 29.03.2009 23:32
> An: empire-db-dev@incubator.apache.org
> Betreff: re: Review of release assembly
>
> Thanks Francis.
> You're as good as gold.
>
> Rainer
>
> Francis De Brabandere wrote:
>> Re: Review of release assembly
>>
>> > In order to go ahead I suggest the following.
>> > 1. The structure of the distribution should be
>> > lib
>> > javadoc
>> > src
>> > examples
>> > I think it would be better to separate the Examples from the Source
>> like CXF does it. At the moment we have it all below Src. Francis,
>> would this be difficult to achive with your Maven build?
>>
>> no problem, the assembly file has the distribution structure definition
>>
>> >
>> > 2. The lib-diretory should contain the following jars:
>> > empire-db-2.0.5.jar
>> > empire-struts2-ext-2.0.5.jar
>> > common-beanutils-1.7.0.jar
>> > common-collections-3.2.1.jar
>> > common-logging-1.0.4.jar
>> > log4j-1.2.14.jar
>> > hsqldb-1.8.0.10.jar
>> > That will be sufficient to compile Empire-db core and the Empire-db
>> core examples. I can provide two additional info files specifying which
>> dependencies are required for the struts2-ext and the cxf-examples. To
>> me this would be an acceptable compromise. In this case we have to
>> provide the license file for HSQLDB in the root. I don't think it's
>> worth having a separate license folder.
>> > Another option would be to supply the required dependencies for
>> Struts2 and CXF too. But this would considerably blow up the size of
>> the release file.
>>
>> ok for me, ppl using maven won't be downloading the the distribution
>> anyway except maybe for the examples
>>
>> >
>> > Concering the SNAPSHOT extension on our jars I have a question
>> (probably best answered by the mentors): The jars are in the archive
>> that we put up for voting. If the vote succeeds, is it acceptable to
>> remove the extension or would it be better to remove the extension
>> beforehand? (Personally I would do the latter).
>>
>> if you release using maven, maven will remove that snapshot tag when
>> performing the actual release (tagging svn + other stuff) so don't
>> worry about it, it's just the way maven works
>>
>> >
>> > Another question to Francis:
>> > When I tried to run the struts2 samples I had another problem. When I
>> chose "Debug on Server" for the empire-db-example-struts2 (using Tomcat
>> 5.5.) I get the following error in the log:
>> > java.lang.NoClassDefFoundError: org/apache/log4j/xml/DOMConfigurator
>> > For some reason log4j is not published to the WEB-INF/lib directory
>> although it seems to be correctly specified as a maven dependency. Do
>> you have any idea why other maven depedencies are copyied and this one
>> is not?
>>
>> i'll fix this
>>
>> > On the other hand the servlet-api-2.4.jar and jsp-api-2.0.jar are
>> published although they should not.
>> > (Personally I am using the sysdeo tomcat plugin with which the
>> examples run fine when configured correctly)
>>
>> i should be able to fix this as well
>>
>> >
>> > Anyone else except for Francis and me having an opinon on the
>> release?
>> > Regards
>> >
>> > Rainer
>> >
>> > Francis De Brabandere wrote:
>> >> Re: Review of release assembly
>> >>
>> >> > 1. The name of the archive must be "apache-empire-db-2.0.5-
>> >> incubating.zip" (or .tar.gz respectively)
>> >>
>> >> name fixed (SNAPSHOT) will be removed when we create an actual
>> release
>> >>
>> >> >
>> >> > 2. The root directory must contain the README.TXT with the Apache
>> >> disclaimer, the LICENSE.TXT containing the Apache License and the
>> >> NOTICE.TXT. If we decide to provide the hsqldb.jar we would also
>> need
>> >> to supply the LICENSE-HSQLDB.txt. Without those files supplied in
>> the
>> >> root directory we will not be able to get the approval of the
>> >> community. I would appreciate to also have the tutorial.pdf there.
>> >> Don't know where to supply the changelog (expecially if we
>> distribute
>> >> core and struts2-ext together)
>> >>
>> >> txt files added
>> >> pdf added
>> >> do we need to add hsqldb? most ppl won't need it.
>> >>
>> >> >
>> >> > 3. I was surprised to find that the size of the archive was 19,3
>> MB.
>> >> The reason was soon discovered: The file empire-db-example-struts2-
>> cxf-
>> >> 2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I
>> don't
>> >> think it makes sense to include the compiled examples. I would
>> prefer
>> >> only to provide the empire-db-2.0.5.jar and the empire-db-struts2-
>> >> 2.0.5.jar (without the "SNAPSHOT").
>> >>
>> >> fixed and SNAPSHOT will be removed when we build an actual release
>> >> (SNAPSHOT is a special maven tag to indicate a transient non-
>> released
>> >> build)
>> >>
>> >> >
>> >> > 4. I was unable to find the javadoc. Is Javadoc generation missing
>> in
>> >> the maven build?
>> >>
>> >> I'll fix this when I got some more time left
>> >>
>> >> >
>> >> > 5. Due to the missing dependencies and project files it is
>> virtually
>> >> impossible for someone who is not familiar with Maven to run any of
>> the
>> >> sample applications. Shouldn't we give a clue how to best set things
>> up
>> >> with Maven and maybe even how to live without?
>> >>
>> >> Any suggestions on how? Site, in txt file, pdf, ...?
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> http://www.somatik.be
>> >> Microsoft gives you windows, Linux gives you the whole house.
>> >
>>
>>
>>
>> --
>> http://www.somatik.be
>> Microsoft gives you windows, Linux gives you the whole house.
>
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Building the release assembly
Posted by Rainer Döbele <do...@esteam.de>.
Hi Francis,
It seems that you have not yet changed the assembly generation to adapt to the changes we have discussed last Sunday (see below).
As you have already seen I have added a file that shows which dependencies are required to build the empire-struts2-ext under empire-db-struts2\src\main\resources. The dependencies listed in there are the minimum requirement to build the empire-struts2-ext jar.
But I have another issue concering the naming of the empire-struts2-ext:
I have delibertately chosen the name not to include the -db since there is no database functionaltiy in there. The package namespace reflects this as well. Hence the name of the jar should be empire-struts2-ext-xxx.jar (with xxx standing for the version string).
The same applies to the Maven artifact id which should be empire-struts2-ext.
Ideally this should also apply to the project name but this would probably be too much hassle to change now.
Also the version string should only be <version>2.0.5-SNAPSHOT</version> (personally I would even remove the SNAPSHOT). I could change this myself, but they are your files and I better ask beforehand.
Concering the naming I would suggest to stick to the naming of our previous release (see http://incubator.apache.org/empire-db/downloads/downloads.htm).
Please let me know, when you have changed the assembly generation so I can check it an possibly put it up for voting.
I think we both want to get this release out asap.
Regards
Rainer
-----Ursprüngliche Nachricht-----
Von: Rainer Döbele [mailto:doebele@esteam.de]
Gesendet: So 29.03.2009 23:32
An: empire-db-dev@incubator.apache.org
Betreff: re: Review of release assembly
Thanks Francis.
You're as good as gold.
Rainer
Francis De Brabandere wrote:
> Re: Review of release assembly
>
> > In order to go ahead I suggest the following.
> > 1. The structure of the distribution should be
> > lib
> > javadoc
> > src
> > examples
> > I think it would be better to separate the Examples from the Source
> like CXF does it. At the moment we have it all below Src. Francis,
> would this be difficult to achive with your Maven build?
>
> no problem, the assembly file has the distribution structure definition
>
> >
> > 2. The lib-diretory should contain the following jars:
> > empire-db-2.0.5.jar
> > empire-struts2-ext-2.0.5.jar
> > common-beanutils-1.7.0.jar
> > common-collections-3.2.1.jar
> > common-logging-1.0.4.jar
> > log4j-1.2.14.jar
> > hsqldb-1.8.0.10.jar
> > That will be sufficient to compile Empire-db core and the Empire-db
> core examples. I can provide two additional info files specifying which
> dependencies are required for the struts2-ext and the cxf-examples. To
> me this would be an acceptable compromise. In this case we have to
> provide the license file for HSQLDB in the root. I don't think it's
> worth having a separate license folder.
> > Another option would be to supply the required dependencies for
> Struts2 and CXF too. But this would considerably blow up the size of
> the release file.
>
> ok for me, ppl using maven won't be downloading the the distribution
> anyway except maybe for the examples
>
> >
> > Concering the SNAPSHOT extension on our jars I have a question
> (probably best answered by the mentors): The jars are in the archive
> that we put up for voting. If the vote succeeds, is it acceptable to
> remove the extension or would it be better to remove the extension
> beforehand? (Personally I would do the latter).
>
> if you release using maven, maven will remove that snapshot tag when
> performing the actual release (tagging svn + other stuff) so don't
> worry about it, it's just the way maven works
>
> >
> > Another question to Francis:
> > When I tried to run the struts2 samples I had another problem. When I
> chose "Debug on Server" for the empire-db-example-struts2 (using Tomcat
> 5.5.) I get the following error in the log:
> > java.lang.NoClassDefFoundError: org/apache/log4j/xml/DOMConfigurator
> > For some reason log4j is not published to the WEB-INF/lib directory
> although it seems to be correctly specified as a maven dependency. Do
> you have any idea why other maven depedencies are copyied and this one
> is not?
>
> i'll fix this
>
> > On the other hand the servlet-api-2.4.jar and jsp-api-2.0.jar are
> published although they should not.
> > (Personally I am using the sysdeo tomcat plugin with which the
> examples run fine when configured correctly)
>
> i should be able to fix this as well
>
> >
> > Anyone else except for Francis and me having an opinon on the
> release?
> > Regards
> >
> > Rainer
> >
> > Francis De Brabandere wrote:
> >> Re: Review of release assembly
> >>
> >> > 1. The name of the archive must be "apache-empire-db-2.0.5-
> >> incubating.zip" (or .tar.gz respectively)
> >>
> >> name fixed (SNAPSHOT) will be removed when we create an actual
> release
> >>
> >> >
> >> > 2. The root directory must contain the README.TXT with the Apache
> >> disclaimer, the LICENSE.TXT containing the Apache License and the
> >> NOTICE.TXT. If we decide to provide the hsqldb.jar we would also
> need
> >> to supply the LICENSE-HSQLDB.txt. Without those files supplied in
> the
> >> root directory we will not be able to get the approval of the
> >> community. I would appreciate to also have the tutorial.pdf there.
> >> Don't know where to supply the changelog (expecially if we
> distribute
> >> core and struts2-ext together)
> >>
> >> txt files added
> >> pdf added
> >> do we need to add hsqldb? most ppl won't need it.
> >>
> >> >
> >> > 3. I was surprised to find that the size of the archive was 19,3
> MB.
> >> The reason was soon discovered: The file empire-db-example-struts2-
> cxf-
> >> 2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I
> don't
> >> think it makes sense to include the compiled examples. I would
> prefer
> >> only to provide the empire-db-2.0.5.jar and the empire-db-struts2-
> >> 2.0.5.jar (without the "SNAPSHOT").
> >>
> >> fixed and SNAPSHOT will be removed when we build an actual release
> >> (SNAPSHOT is a special maven tag to indicate a transient non-
> released
> >> build)
> >>
> >> >
> >> > 4. I was unable to find the javadoc. Is Javadoc generation missing
> in
> >> the maven build?
> >>
> >> I'll fix this when I got some more time left
> >>
> >> >
> >> > 5. Due to the missing dependencies and project files it is
> virtually
> >> impossible for someone who is not familiar with Maven to run any of
> the
> >> sample applications. Shouldn't we give a clue how to best set things
> up
> >> with Maven and maybe even how to live without?
> >>
> >> Any suggestions on how? Site, in txt file, pdf, ...?
> >>
> >>
> >>
> >>
> >> --
> >> http://www.somatik.be
> >> Microsoft gives you windows, Linux gives you the whole house.
> >
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
re: Review of release assembly
Posted by Rainer Döbele <do...@esteam.de>.
Thanks Francis.
You're as good as gold.
Rainer
Francis De Brabandere wrote:
> Re: Review of release assembly
>
> > In order to go ahead I suggest the following.
> > 1. The structure of the distribution should be
> > lib
> > javadoc
> > src
> > examples
> > I think it would be better to separate the Examples from the Source
> like CXF does it. At the moment we have it all below Src. Francis,
> would this be difficult to achive with your Maven build?
>
> no problem, the assembly file has the distribution structure definition
>
> >
> > 2. The lib-diretory should contain the following jars:
> > empire-db-2.0.5.jar
> > empire-struts2-ext-2.0.5.jar
> > common-beanutils-1.7.0.jar
> > common-collections-3.2.1.jar
> > common-logging-1.0.4.jar
> > log4j-1.2.14.jar
> > hsqldb-1.8.0.10.jar
> > That will be sufficient to compile Empire-db core and the Empire-db
> core examples. I can provide two additional info files specifying which
> dependencies are required for the struts2-ext and the cxf-examples. To
> me this would be an acceptable compromise. In this case we have to
> provide the license file for HSQLDB in the root. I don't think it's
> worth having a separate license folder.
> > Another option would be to supply the required dependencies for
> Struts2 and CXF too. But this would considerably blow up the size of
> the release file.
>
> ok for me, ppl using maven won't be downloading the the distribution
> anyway except maybe for the examples
>
> >
> > Concering the SNAPSHOT extension on our jars I have a question
> (probably best answered by the mentors): The jars are in the archive
> that we put up for voting. If the vote succeeds, is it acceptable to
> remove the extension or would it be better to remove the extension
> beforehand? (Personally I would do the latter).
>
> if you release using maven, maven will remove that snapshot tag when
> performing the actual release (tagging svn + other stuff) so don't
> worry about it, it's just the way maven works
>
> >
> > Another question to Francis:
> > When I tried to run the struts2 samples I had another problem. When I
> chose "Debug on Server" for the empire-db-example-struts2 (using Tomcat
> 5.5.) I get the following error in the log:
> > java.lang.NoClassDefFoundError: org/apache/log4j/xml/DOMConfigurator
> > For some reason log4j is not published to the WEB-INF/lib directory
> although it seems to be correctly specified as a maven dependency. Do
> you have any idea why other maven depedencies are copyied and this one
> is not?
>
> i'll fix this
>
> > On the other hand the servlet-api-2.4.jar and jsp-api-2.0.jar are
> published although they should not.
> > (Personally I am using the sysdeo tomcat plugin with which the
> examples run fine when configured correctly)
>
> i should be able to fix this as well
>
> >
> > Anyone else except for Francis and me having an opinon on the
> release?
> > Regards
> >
> > Rainer
> >
> > Francis De Brabandere wrote:
> >> Re: Review of release assembly
> >>
> >> > 1. The name of the archive must be "apache-empire-db-2.0.5-
> >> incubating.zip" (or .tar.gz respectively)
> >>
> >> name fixed (SNAPSHOT) will be removed when we create an actual
> release
> >>
> >> >
> >> > 2. The root directory must contain the README.TXT with the Apache
> >> disclaimer, the LICENSE.TXT containing the Apache License and the
> >> NOTICE.TXT. If we decide to provide the hsqldb.jar we would also
> need
> >> to supply the LICENSE-HSQLDB.txt. Without those files supplied in
> the
> >> root directory we will not be able to get the approval of the
> >> community. I would appreciate to also have the tutorial.pdf there.
> >> Don't know where to supply the changelog (expecially if we
> distribute
> >> core and struts2-ext together)
> >>
> >> txt files added
> >> pdf added
> >> do we need to add hsqldb? most ppl won't need it.
> >>
> >> >
> >> > 3. I was surprised to find that the size of the archive was 19,3
> MB.
> >> The reason was soon discovered: The file empire-db-example-struts2-
> cxf-
> >> 2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I
> don't
> >> think it makes sense to include the compiled examples. I would
> prefer
> >> only to provide the empire-db-2.0.5.jar and the empire-db-struts2-
> >> 2.0.5.jar (without the "SNAPSHOT").
> >>
> >> fixed and SNAPSHOT will be removed when we build an actual release
> >> (SNAPSHOT is a special maven tag to indicate a transient non-
> released
> >> build)
> >>
> >> >
> >> > 4. I was unable to find the javadoc. Is Javadoc generation missing
> in
> >> the maven build?
> >>
> >> I'll fix this when I got some more time left
> >>
> >> >
> >> > 5. Due to the missing dependencies and project files it is
> virtually
> >> impossible for someone who is not familiar with Maven to run any of
> the
> >> sample applications. Shouldn't we give a clue how to best set things
> up
> >> with Maven and maybe even how to live without?
> >>
> >> Any suggestions on how? Site, in txt file, pdf, ...?
> >>
> >>
> >>
> >>
> >> --
> >> http://www.somatik.be
> >> Microsoft gives you windows, Linux gives you the whole house.
> >
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
Re: Review of release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
>> Another question to Francis:
>> When I tried to run the struts2 samples I had another problem. When I chose "Debug on Server" for the empire-db-example-struts2 (using Tomcat 5.5.) I get the following error in the log:
>> java.lang.NoClassDefFoundError: org/apache/log4j/xml/DOMConfigurator
>> For some reason log4j is not published to the WEB-INF/lib directory although it seems to be correctly specified as a maven dependency. Do you have any idea why other maven depedencies are copyied and this one is not?
>
> i'll fix this
I added log4j in the struts2 example dependencies
the struts2-cxf example seems to be using slf4j-jdk logging, I suppose
it needs log4j as well (might be better to use slf4j-log4j then)?
>
>> On the other hand the servlet-api-2.4.jar and jsp-api-2.0.jar are published although they should not.
>> (Personally I am using the sysdeo tomcat plugin with which the examples run fine when configured correctly)
>
> i should be able to fix this as well
>
this depends on the scope of the dependency: see
http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope
fixed, put them to scope "provided" (in parent pom dep management)
please check if both are ok now
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: Review of release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
> In order to go ahead I suggest the following.
> 1. The structure of the distribution should be
> lib
> javadoc
> src
> examples
> I think it would be better to separate the Examples from the Source like CXF does it. At the moment we have it all below Src. Francis, would this be difficult to achive with your Maven build?
no problem, the assembly file has the distribution structure definition
>
> 2. The lib-diretory should contain the following jars:
> empire-db-2.0.5.jar
> empire-struts2-ext-2.0.5.jar
> common-beanutils-1.7.0.jar
> common-collections-3.2.1.jar
> common-logging-1.0.4.jar
> log4j-1.2.14.jar
> hsqldb-1.8.0.10.jar
> That will be sufficient to compile Empire-db core and the Empire-db core examples. I can provide two additional info files specifying which dependencies are required for the struts2-ext and the cxf-examples. To me this would be an acceptable compromise. In this case we have to provide the license file for HSQLDB in the root. I don't think it's worth having a separate license folder.
> Another option would be to supply the required dependencies for Struts2 and CXF too. But this would considerably blow up the size of the release file.
ok for me, ppl using maven won't be downloading the the distribution
anyway except maybe for the examples
>
> Concering the SNAPSHOT extension on our jars I have a question (probably best answered by the mentors): The jars are in the archive that we put up for voting. If the vote succeeds, is it acceptable to remove the extension or would it be better to remove the extension beforehand? (Personally I would do the latter).
if you release using maven, maven will remove that snapshot tag when
performing the actual release (tagging svn + other stuff) so don't
worry about it, it's just the way maven works
>
> Another question to Francis:
> When I tried to run the struts2 samples I had another problem. When I chose "Debug on Server" for the empire-db-example-struts2 (using Tomcat 5.5.) I get the following error in the log:
> java.lang.NoClassDefFoundError: org/apache/log4j/xml/DOMConfigurator
> For some reason log4j is not published to the WEB-INF/lib directory although it seems to be correctly specified as a maven dependency. Do you have any idea why other maven depedencies are copyied and this one is not?
i'll fix this
> On the other hand the servlet-api-2.4.jar and jsp-api-2.0.jar are published although they should not.
> (Personally I am using the sysdeo tomcat plugin with which the examples run fine when configured correctly)
i should be able to fix this as well
>
> Anyone else except for Francis and me having an opinon on the release?
> Regards
>
> Rainer
>
> Francis De Brabandere wrote:
>> Re: Review of release assembly
>>
>> > 1. The name of the archive must be "apache-empire-db-2.0.5-
>> incubating.zip" (or .tar.gz respectively)
>>
>> name fixed (SNAPSHOT) will be removed when we create an actual release
>>
>> >
>> > 2. The root directory must contain the README.TXT with the Apache
>> disclaimer, the LICENSE.TXT containing the Apache License and the
>> NOTICE.TXT. If we decide to provide the hsqldb.jar we would also need
>> to supply the LICENSE-HSQLDB.txt. Without those files supplied in the
>> root directory we will not be able to get the approval of the
>> community. I would appreciate to also have the tutorial.pdf there.
>> Don't know where to supply the changelog (expecially if we distribute
>> core and struts2-ext together)
>>
>> txt files added
>> pdf added
>> do we need to add hsqldb? most ppl won't need it.
>>
>> >
>> > 3. I was surprised to find that the size of the archive was 19,3 MB.
>> The reason was soon discovered: The file empire-db-example-struts2-cxf-
>> 2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I don't
>> think it makes sense to include the compiled examples. I would prefer
>> only to provide the empire-db-2.0.5.jar and the empire-db-struts2-
>> 2.0.5.jar (without the "SNAPSHOT").
>>
>> fixed and SNAPSHOT will be removed when we build an actual release
>> (SNAPSHOT is a special maven tag to indicate a transient non-released
>> build)
>>
>> >
>> > 4. I was unable to find the javadoc. Is Javadoc generation missing in
>> the maven build?
>>
>> I'll fix this when I got some more time left
>>
>> >
>> > 5. Due to the missing dependencies and project files it is virtually
>> impossible for someone who is not familiar with Maven to run any of the
>> sample applications. Shouldn't we give a clue how to best set things up
>> with Maven and maybe even how to live without?
>>
>> Any suggestions on how? Site, in txt file, pdf, ...?
>>
>>
>>
>>
>> --
>> http://www.somatik.be
>> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: Review of release assembly
Posted by Rainer Döbele <do...@esteam.de>.
Hello everyone,
Regarding our upcoming release I have had a look at apache-cxf-2.2 and myfaces-core-1.2.6 and apache-wicket-1.4.rc2. All three seem to provide a considerably different layout.
Where cxf and myfaces seem to supply all required dependencies, wicket seems not.
There are many more differences on the archive structure and the contents.
However all distributions supply the javadoc.
In order to go ahead I suggest the following.
1. The structure of the distribution should be
lib
javadoc
src
examples
I think it would be better to separate the Examples from the Source like CXF does it. At the moment we have it all below Src. Francis, would this be difficult to achive with your Maven build?
2. The lib-diretory should contain the following jars:
empire-db-2.0.5.jar
empire-struts2-ext-2.0.5.jar
common-beanutils-1.7.0.jar
common-collections-3.2.1.jar
common-logging-1.0.4.jar
log4j-1.2.14.jar
hsqldb-1.8.0.10.jar
That will be sufficient to compile Empire-db core and the Empire-db core examples. I can provide two additional info files specifying which dependencies are required for the struts2-ext and the cxf-examples. To me this would be an acceptable compromise. In this case we have to provide the license file for HSQLDB in the root. I don't think it's worth having a separate license folder.
Another option would be to supply the required dependencies for Struts2 and CXF too. But this would considerably blow up the size of the release file.
Concering the SNAPSHOT extension on our jars I have a question (probably best answered by the mentors): The jars are in the archive that we put up for voting. If the vote succeeds, is it acceptable to remove the extension or would it be better to remove the extension beforehand? (Personally I would do the latter).
Another question to Francis:
When I tried to run the struts2 samples I had another problem. When I chose "Debug on Server" for the empire-db-example-struts2 (using Tomcat 5.5.) I get the following error in the log:
java.lang.NoClassDefFoundError: org/apache/log4j/xml/DOMConfigurator
For some reason log4j is not published to the WEB-INF/lib directory although it seems to be correctly specified as a maven dependency. Do you have any idea why other maven depedencies are copyied and this one is not?
On the other hand the servlet-api-2.4.jar and jsp-api-2.0.jar are published although they should not.
(Personally I am using the sysdeo tomcat plugin with which the examples run fine when configured correctly)
Anyone else except for Francis and me having an opinon on the release?
Regards
Rainer
Francis De Brabandere wrote:
> Re: Review of release assembly
>
> > 1. The name of the archive must be "apache-empire-db-2.0.5-
> incubating.zip" (or .tar.gz respectively)
>
> name fixed (SNAPSHOT) will be removed when we create an actual release
>
> >
> > 2. The root directory must contain the README.TXT with the Apache
> disclaimer, the LICENSE.TXT containing the Apache License and the
> NOTICE.TXT. If we decide to provide the hsqldb.jar we would also need
> to supply the LICENSE-HSQLDB.txt. Without those files supplied in the
> root directory we will not be able to get the approval of the
> community. I would appreciate to also have the tutorial.pdf there.
> Don't know where to supply the changelog (expecially if we distribute
> core and struts2-ext together)
>
> txt files added
> pdf added
> do we need to add hsqldb? most ppl won't need it.
>
> >
> > 3. I was surprised to find that the size of the archive was 19,3 MB.
> The reason was soon discovered: The file empire-db-example-struts2-cxf-
> 2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I don't
> think it makes sense to include the compiled examples. I would prefer
> only to provide the empire-db-2.0.5.jar and the empire-db-struts2-
> 2.0.5.jar (without the "SNAPSHOT").
>
> fixed and SNAPSHOT will be removed when we build an actual release
> (SNAPSHOT is a special maven tag to indicate a transient non-released
> build)
>
> >
> > 4. I was unable to find the javadoc. Is Javadoc generation missing in
> the maven build?
>
> I'll fix this when I got some more time left
>
> >
> > 5. Due to the missing dependencies and project files it is virtually
> impossible for someone who is not familiar with Maven to run any of the
> sample applications. Shouldn't we give a clue how to best set things up
> with Maven and maybe even how to live without?
>
> Any suggestions on how? Site, in txt file, pdf, ...?
>
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
Re: Review of release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
>> 4. I was unable to find the javadoc. Is Javadoc generation missing in the maven build?
>
> I'll fix this when I got some more time left
>
this one is fixed
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: Review of release assembly
Posted by Francis De Brabandere <fr...@gmail.com>.
> 1. The name of the archive must be "apache-empire-db-2.0.5-incubating.zip" (or .tar.gz respectively)
name fixed (SNAPSHOT) will be removed when we create an actual release
>
> 2. The root directory must contain the README.TXT with the Apache disclaimer, the LICENSE.TXT containing the Apache License and the NOTICE.TXT. If we decide to provide the hsqldb.jar we would also need to supply the LICENSE-HSQLDB.txt. Without those files supplied in the root directory we will not be able to get the approval of the community. I would appreciate to also have the tutorial.pdf there. Don't know where to supply the changelog (expecially if we distribute core and struts2-ext together)
txt files added
pdf added
do we need to add hsqldb? most ppl won't need it.
>
> 3. I was surprised to find that the size of the archive was 19,3 MB. The reason was soon discovered: The file empire-db-example-struts2-cxf-2.0.5-SNAPSHOT.war in the lib directory has 13,2 MB on its own. I don't think it makes sense to include the compiled examples. I would prefer only to provide the empire-db-2.0.5.jar and the empire-db-struts2-2.0.5.jar (without the "SNAPSHOT").
fixed and SNAPSHOT will be removed when we build an actual release
(SNAPSHOT is a special maven tag to indicate a transient non-released
build)
>
> 4. I was unable to find the javadoc. Is Javadoc generation missing in the maven build?
I'll fix this when I got some more time left
>
> 5. Due to the missing dependencies and project files it is virtually impossible for someone who is not familiar with Maven to run any of the sample applications. Shouldn't we give a clue how to best set things up with Maven and maybe even how to live without?
Any suggestions on how? Site, in txt file, pdf, ...?
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.