[GitHub] [couchdb-fauxton] Antonio-Maranhao opened a new pull request #1314: Fix: Changes page generates incorrect link for doc IDs with special chars

[GitBox <gi...@apache.org>]

Antonio-Maranhao opened a new pull request #1314:
URL: https://github.com/apache/couchdb-fauxton/pull/1314


   ## Overview
   
   Changes page generates incorrect link for doc IDs with special chars.
   The fix is to URL encode the doc ID and database name when generating the URL.
   
   ## Testing recommendations
   
   1. Create a document with ID `test\n\r_?`
   2. Go to Changes page and scroll the list to find the entry for the new doc
   3. Click on the link. It should load the document in the editor
   
   ## GitHub issue number
   
   none
   
   ## Related Pull Requests
   
   none
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct tag once a new Fauxton release is made
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-fauxton] Antonio-Maranhao merged pull request #1314: Fix: Changes page generates incorrect link for doc IDs with special chars

[GitBox <gi...@apache.org>]

Antonio-Maranhao merged pull request #1314:
URL: https://github.com/apache/couchdb-fauxton/pull/1314


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org