You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/07 07:33:32 UTC
[GitHub] [dubbo-go-pixiu] mark4z opened a new pull request, #393: Lds
mark4z opened a new pull request, #393:
URL: https://github.com/apache/dubbo-go-pixiu/pull/393
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #393: [WIP] LDS
Posted by GitBox <gi...@apache.org>.
mark4z commented on code in PR #393:
URL: https://github.com/apache/dubbo-go-pixiu/pull/393#discussion_r849488179
##########
pkg/config/xds/apiclient/grpc.go:
##########
@@ -19,6 +19,8 @@ package apiclient
import (
"context"
+ errors2 "errors"
Review Comment:
fixed by #385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a diff in pull request #393: [WIP] LDS
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #393:
URL: https://github.com/apache/dubbo-go-pixiu/pull/393#discussion_r854775297
##########
pkg/config/xds/lds_test.go:
##########
@@ -18,6 +18,9 @@
package xds
import (
+ "github.com/apache/dubbo-go-pixiu/pkg/model"
Review Comment:
split it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z closed pull request #393: LDS
Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #393: LDS
URL: https://github.com/apache/dubbo-go-pixiu/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a diff in pull request #393: [WIP] LDS
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #393:
URL: https://github.com/apache/dubbo-go-pixiu/pull/393#discussion_r846953362
##########
pkg/config/xds/apiclient/grpc.go:
##########
@@ -19,6 +19,8 @@ package apiclient
import (
"context"
+ errors2 "errors"
Review Comment:
不建议这么改动 go 原生的 package name。不行了你使用 “perrors \"github.com/pkg/errors\"”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org