[jira] [Commented] (WICKET-6963) Use singletons for PanelMarkupSourcingStrategy

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510026#comment-17510026 ] 

ASF GitHub Bot commented on WICKET-6963:
----------------------------------------

theigl opened a new pull request #503:
URL: https://github.com/apache/wicket/pull/503


   My latest production heapdump contained 2 million of these stateless objects. This PR introduces two singletons for `PanelMarkupSourcingStrategy` instead of allocating new objects for every component.
   
   https://issues.apache.org/jira/browse/WICKET-6963
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use singletons for PanelMarkupSourcingStrategy
> ----------------------------------------------
>
>                 Key: WICKET-6963
>                 URL: https://issues.apache.org/jira/browse/WICKET-6963
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 9.8.0
>            Reporter: Thomas Heigl
>            Assignee: Thomas Heigl
>            Priority: Major
>         Attachments: image-2022-03-21-18-21-51-613.png
>
>
> My latest heapdump contained millions of instances of {{{}PanelMarkupSourcingStrategy{}}}:
> !image-2022-03-21-18-21-51-613.png|width=839,height=24!
> This class is completely stateless and only takes a single boolean constructor parameter. We should replace current instances by a factory method and two singletons.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)