You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2025/01/23 10:53:53 UTC
[PR] feat(dsl): camel jbang export property [camel]
squakez opened a new pull request, #16901:
URL: https://github.com/apache/camel/pull/16901
You can now use `camel export --property xyz=abc`
Closes CAMEL-21645
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(dsl): camel jbang export property [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #16901:
URL: https://github.com/apache/camel/pull/16901#issuecomment-2609635850
You can export foo.java application.properties and other files together. Either explicit name the files, or use `*` etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(dsl): camel jbang export property [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #16901:
URL: https://github.com/apache/camel/pull/16901#issuecomment-2610151359
> You can export foo.java application.properties and other files together. Either explicit name the files, or use `*` etc
I've tested against an export with `application.properties` and I think this is working correctly as it overrides the existing value since the parameter should have priority over the existing values. I created a test to validate this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(dsl): camel jbang export property [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #16901:
URL: https://github.com/apache/camel/pull/16901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(dsl): camel jbang export property [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #16901:
URL: https://github.com/apache/camel/pull/16901#issuecomment-2609535273
I wonder if --property should override any existing value that may already be when writing the application.properties
so if you already have `hello = peter` and then export with --property=hello=jack --- then the written file will a single property with jack as the value. Otherwise you have duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(dsl): camel jbang export property [camel]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #16901:
URL: https://github.com/apache/camel/pull/16901#issuecomment-2609540173
> I wonder if --property should override any existing value that may already be when writing the application.properties
>
> so if you already have `hello = peter` and then export with --property=hello=jack --- then the written file will a single property with jack as the value. Otherwise you have duplicates.
The fact is that, at that stage the application.properties is completely blank as we're exporting an app from scratch. The presence of duplicates can only happen if the user forcefully provide twice the same parameter key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org