[GitHub] [hbase] wchevreuil commented on a change in pull request #3851: HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #3851:
URL: https://github.com/apache/hbase/pull/3851#discussion_r751289439



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -877,9 +943,14 @@ public long restoreOrCloneSnapshot(final SnapshotDescription reqSnapshot, final
    */
   private long restoreSnapshot(final SnapshotDescription reqSnapshot, final TableName tableName,
       final SnapshotDescription snapshot, final TableDescriptor snapshotTableDesc,
-      final NonceKey nonceKey, final boolean restoreAcl) throws IOException {
+      final NonceKey nonceKey, final boolean restoreAcl)
+    throws IOException {

Review comment:
       nit: unnecessary line break

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -877,9 +943,14 @@ public long restoreOrCloneSnapshot(final SnapshotDescription reqSnapshot, final
    */
   private long restoreSnapshot(final SnapshotDescription reqSnapshot, final TableName tableName,
       final SnapshotDescription snapshot, final TableDescriptor snapshotTableDesc,
-      final NonceKey nonceKey, final boolean restoreAcl) throws IOException {
+      final NonceKey nonceKey, final boolean restoreAcl)
+    throws IOException {
     MasterCoprocessorHost cpHost = master.getMasterCoprocessorHost();
 
+    //have to check first if restoring the snapshot would break current SFT setup
+    checkSFTCompatibility(master.getTableDescriptors().get(tableName), snapshotTableDesc,

Review comment:
       Do we really need all these complex combinations? Could we just check if the SFT conf between current descriptor and snapshot descriptor differs, then fail it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org