You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/06 14:55:24 UTC

[GitHub] [flink] dmvk commented on a change in pull request #17160: [FLINK-23961][kubernetes] Hint user about missing 'kubernetes.cluster…

dmvk commented on a change in pull request #17160:
URL: https://github.com/apache/flink/pull/17160#discussion_r702957194



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -85,7 +85,15 @@ public Fabric8FlinkKubeClient(
             Configuration flinkConfig,
             NamespacedKubernetesClient client,
             ExecutorService executorService) {
-        this.clusterId = checkNotNull(flinkConfig.getString(KubernetesConfigOptions.CLUSTER_ID));
+        this.clusterId =

Review comment:
       `NullPointerException` didn't really feel suitable here as this is basically a misconfiguration on the user side.
   
   NPE is more suitable for API misuse (something that can be basically avoided doing static code analysis).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org