You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2026/10/12 16:48:07 UTC

[PR] [FLINK-40979][table-planner] Run HashAggITCase's inherited tests with adaptive local hash agg [flink]

MartijnVisser opened a new pull request, #29467:
URL: https://github.com/apache/flink/pull/29467

   ## What is the purpose of the change
   
   Since FLINK-32059, the tests `HashAggITCase` inherits from `AggregateITCaseBase` only run with adaptive local hash aggregation disabled.
   
   ## Brief change log
   
   - `HashAggITCase` no longer uses `ParameterizedTestExtension`; its own tests are plain `@Test`.
   - New `AdaptiveLocalHashAggITCase` runs the same class with adaptive local hash aggregation enabled.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `HashAggITCase`. With the suppressed-output branch in `HashAggCodeGenerator` broken on purpose, 2 tests fail on master and 25 fail with this change.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-40979][table-planner] Run HashAggITCase's inherited tests with adaptive local hash agg [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #29467:
URL: https://github.com/apache/flink/pull/29467#issuecomment-6131896404

   Agreed, `AdaptiveLocalHashAggITCase` is Java now. Porting `HashAggITCase` alone means rewriting its `checkQuery` tests by hand while `AggregateITCaseBase` stays Scala, so I'll file a follow-up for all three.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-40979][table-planner] Run HashAggITCase's inherited tests with adaptive local hash agg [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #29467:
URL: https://github.com/apache/flink/pull/29467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-40979][table-planner] Run HashAggITCase's inherited tests with adaptive local hash agg [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29467:
URL: https://github.com/apache/flink/pull/29467#issuecomment-6128850076

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d35e60d681f3605ff0d41cbd3995c7fede7b9d1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2d35e60d681f3605ff0d41cbd3995c7fede7b9d1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d35e60d681f3605ff0d41cbd3995c7fede7b9d1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org