You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 16:21:02 UTC
[GitHub] [airflow] fzylogic opened a new pull request #15923: Properly set the try_number when rescheduling
fzylogic opened a new pull request #15923:
URL: https://github.com/apache/airflow/pull/15923
When a sensor is set to `rescheduling` mode, try_number is incremented but then immediately reset to 1, which in turn breaks exponential_backoff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15923: Properly set the try_number when rescheduling
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15923:
URL: https://github.com/apache/airflow/pull/15923#issuecomment-843319659
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fzylogic commented on a change in pull request #15923: Properly set the try_number when rescheduling
Posted by GitBox <gi...@apache.org>.
fzylogic commented on a change in pull request #15923:
URL: https://github.com/apache/airflow/pull/15923#discussion_r634606390
##########
File path: airflow/sensors/base.py
##########
@@ -220,7 +221,6 @@ def run_duration() -> float:
nonlocal started_at
return time.monotonic() - started_at
- try_number = 1
Review comment:
I had it running in a docker environment for a few days with no obvious issues (including some added debugging code to show the behavior of exponential_fallback was fixed as expected). Logs were all stored together properly in my environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #15923: Properly set the try_number when rescheduling
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #15923:
URL: https://github.com/apache/airflow/pull/15923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15923: Properly set the try_number when rescheduling
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15923:
URL: https://github.com/apache/airflow/pull/15923#issuecomment-881778758
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #15923: Properly set the try_number when rescheduling
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #15923:
URL: https://github.com/apache/airflow/pull/15923#discussion_r634552162
##########
File path: airflow/sensors/base.py
##########
@@ -220,7 +221,6 @@ def run_duration() -> float:
nonlocal started_at
return time.monotonic() - started_at
- try_number = 1
Review comment:
Have you tested it? I think there was an issue with this - for example logs in UI will be different for separate tries. cc @ashb with whom we discussed it some time ago due to #10790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org