You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/16 16:03:00 UTC
[jira] [Commented] (SUREFIRE-1391) System Property variables
processed twice in calculation of effective properties
[ https://issues.apache.org/jira/browse/SUREFIRE-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088978#comment-16088978 ]
ASF GitHub Bot commented on SUREFIRE-1391:
------------------------------------------
GitHub user andrew-j-cohen opened a pull request:
https://github.com/apache/maven-surefire/pull/159
SUREFIRE-1391: Eliminate redundant call in calculation of effective properties
Eliminate redundant call to copy systemPropertyVariables in the calculation of effective properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrew-j-cohen/maven-surefire master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit d2fa7859eed0742b2d6db9b356b29c9e3cf5c04b
Author: Andrew Cohen <ac...@gmail.com>
Date: 2017-07-16T15:48:31Z
SUREFIRE-1391: Eliminate redundant call to process systemPropertyVariables in the calculation of effective properties
Signed-off-by: Andrew Cohen <ac...@gmail.com>
----
> System Property variables processed twice in calculation of effective properties
> --------------------------------------------------------------------------------
>
> Key: SUREFIRE-1391
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1391
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Reporter: Andrew Cohen
> Priority: Trivial
> Attachments: 0001-SUREFIRE-1391-Eliminate-redundant-call-to-process-sy.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> System property variables are processed twice in the calculation of effective properties. There is obviously no adverse impact on behavior, just unnecessary processing.
> {code:java}
> static SurefireProperties calculateEffectiveProperties( Properties systemProperties,
> Map<String, String> systemPropertyVariables,
> Properties userProperties, SurefireProperties props )
> {
> SurefireProperties result = new SurefireProperties();
> result.copyPropertiesFrom( systemProperties );
> result.copyPropertiesFrom( props );
> copyProperties( result, systemPropertyVariables );
> copyProperties( result, systemPropertyVariables );
> // We used to take all of our system properties and dump them in with the
> // user specified properties for SUREFIRE-121, causing SUREFIRE-491.
> // Not gonna do THAT any more... instead, we only propagate those system properties
> // that have been explicitly specified by the user via -Dkey=value on the CLI
> result.copyPropertiesFrom( userProperties );
> return result;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)