You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/27 07:01:56 UTC

[GitHub] [apisix] xyz2b opened a new issue #2330: request help: Apisix host configuration of route can not be '*' ?

xyz2b opened a new issue #2330:
URL: https://github.com/apache/apisix/issues/2330


   ### Issue description
   Apisix host configuration of route can not be '*' ?
   
   ![image](https://user-images.githubusercontent.com/48942966/94358181-bdf44800-00d1-11eb-8bd2-29866307ee1b.png)
   
   I test radixtree can support '*' configuration of host. In the apisix soure code, I find host configuration restrictions. I want to understand why such a restriction in host.
   `local host_def_pat = "^\\*?[0-9a-zA-Z-.]+$|^\\*$"`
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):1.5
   * OS:Centos7.x
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] xyz2b removed a comment on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
xyz2b removed a comment on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703504248


   Sorry. The last condition of this regular expression (^\\*$) is added by myself. The regular expression in the original code is `local host_def_pat = "^\\*?[0-9a-zA-Z-.]+$"`. So, I want to know why the host limit cannot be config '*'.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] xyz2b commented on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
xyz2b commented on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703505259


   Sorry. The last condition of this regular expression `|^\\*$` is added by myself. The regular expression in the original code is `local host_def_pat = "^\*?[0-9a-zA-Z-.]+$"`. So, I want to know why the host limit cannot be config `*`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] xyz2b commented on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
xyz2b commented on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-704011141


   ok, thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] xyz2b commented on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
xyz2b commented on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703504707


   Sorry. The last condition of this regular expression `|^\\*$` is added by myself. The regular expression in the original code is local host_def_pat = "^\\*?[0-9a-zA-Z-.]+$". So, I want to know why the host limit cannot be config `*`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis commented on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703685591


   if you set `*` for field `host`, it means matching any host.
   
   for this case, you do not need to set field `host`.
   
   > So, I want to know why the host limit cannot be config *.
   
   if you want to set  host to `*`, you do not need to set the field "host".


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] moonming commented on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703370940


   @membphis please take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] xyz2b removed a comment on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
xyz2b removed a comment on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703504707


   Sorry. The last condition of this regular expression `|^\\*$` is added by myself. The regular expression in the original code is local host_def_pat = "^\\*?[0-9a-zA-Z-.]+$". So, I want to know why the host limit cannot be config `*`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] xyz2b commented on issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
xyz2b commented on issue #2330:
URL: https://github.com/apache/apisix/issues/2330#issuecomment-703504248


   Sorry. The last condition of this regular expression (^\\*$) is added by myself. The regular expression in the original code is `local host_def_pat = "^\\*?[0-9a-zA-Z-.]+$"`. So, I want to know why the host limit cannot be config '*'.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis closed issue #2330: request help: Apisix host configuration of route can not be '*' ?

Posted by GitBox <gi...@apache.org>.
membphis closed issue #2330:
URL: https://github.com/apache/apisix/issues/2330


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org