You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2021/05/31 06:38:00 UTC
[incubator-nuttx] branch master updated (02b244c -> 7ac6c0a)
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 02b244c arch: arm: update licenses to Apache
new 0c606ec psock_tcp_recvfrom: Add a comment about window updates
new 2ce0457 tcp_get_recvwindow: Add a comment
new 9232879 tcp_data_event: Fix an indent
new 70d215b devif_poll_tcp_connections: Fix a comment typo
new 7ac6c0a tcp_data_event: Add a comment
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
net/devif/devif_poll.c | 2 +-
net/tcp/tcp_callback.c | 8 ++++++--
net/tcp/tcp_recvfrom.c | 7 ++++++-
net/tcp/tcp_recvwindow.c | 3 +++
4 files changed, 16 insertions(+), 4 deletions(-)
[incubator-nuttx] 02/05: tcp_get_recvwindow: Add a comment
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2ce0457edb048272ba97b35a414e23f76bf7586d
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:03:55 2021 +0900
tcp_get_recvwindow: Add a comment
---
net/tcp/tcp_recvwindow.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/tcp/tcp_recvwindow.c b/net/tcp/tcp_recvwindow.c
index 795f715..4d81f14 100644
--- a/net/tcp/tcp_recvwindow.c
+++ b/net/tcp/tcp_recvwindow.c
@@ -136,6 +136,9 @@ uint16_t tcp_get_recvwindow(FAR struct net_driver_s *dev,
{
/* Advertise maximum segment size for window edge if here is no
* available iobs on current "free" connection.
+ *
+ * Note: hopefully, a single mss-sized packet can be queued by
+ * the throttled=false case in tcp_datahandler().
*/
recvwndo = mss;
[incubator-nuttx] 01/05: psock_tcp_recvfrom: Add a comment about
window updates
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0c606ecb8e0048840639f52bc7268e8b63ada2bd
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:02:42 2021 +0900
psock_tcp_recvfrom: Add a comment about window updates
---
net/tcp/tcp_recvfrom.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/tcp/tcp_recvfrom.c b/net/tcp/tcp_recvfrom.c
index 1d11d76..973a5c5 100644
--- a/net/tcp/tcp_recvfrom.c
+++ b/net/tcp/tcp_recvfrom.c
@@ -809,7 +809,12 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR void *buf,
}
}
- /* Receive additional data from read-ahead buffer, send the ACK timely. */
+ /* Receive additional data from read-ahead buffer, send the ACK timely.
+ *
+ * Revisit: Because IOBs are system-wide resources, consuming the read
+ * ahead buffer would update recv window of all connections in the system,
+ * not only this particular connection.
+ */
if (conn->rcv_wnd == 0 && conn->rcv_ackcb == NULL)
{
[incubator-nuttx] 03/05: tcp_data_event: Fix an indent
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 92328792fd3ac04e62ddfeaaa1f035beb8b47c19
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:09:02 2021 +0900
tcp_data_event: Fix an indent
---
net/tcp/tcp_callback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tcp/tcp_callback.c b/net/tcp/tcp_callback.c
index 953a4dc..c717512 100644
--- a/net/tcp/tcp_callback.c
+++ b/net/tcp/tcp_callback.c
@@ -91,7 +91,7 @@ tcp_data_event(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn,
* read-ahead buffers to retain the data -- drop the packet.
*/
- ninfo("Dropped %d bytes\n", dev->d_len);
+ ninfo("Dropped %d bytes\n", dev->d_len);
#ifdef CONFIG_NET_STATISTICS
g_netstats.tcp.drop++;
[incubator-nuttx] 04/05: devif_poll_tcp_connections: Fix a comment
typo
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 70d215b11f0b574cd07a66fa2c5cfe730eb7cb99
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:43:24 2021 +0900
devif_poll_tcp_connections: Fix a comment typo
---
net/devif/devif_poll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/devif/devif_poll.c b/net/devif/devif_poll.c
index 71f83bf..6865742 100644
--- a/net/devif/devif_poll.c
+++ b/net/devif/devif_poll.c
@@ -554,7 +554,7 @@ static int devif_poll_udp_connections(FAR struct net_driver_s *dev,
* Name: devif_poll_tcp_connections
*
* Description:
- * Poll all UDP connections for available packets to send.
+ * Poll all TCP connections for available packets to send.
*
* Assumptions:
* This function is called from the MAC device driver with the network
[incubator-nuttx] 05/05: tcp_data_event: Add a comment
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7ac6c0a8de539c7034a022cde99b67d77ad74f52
Author: YAMAMOTO Takashi <ya...@midokura.com>
AuthorDate: Fri May 28 17:44:13 2021 +0900
tcp_data_event: Add a comment
---
net/tcp/tcp_callback.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/tcp/tcp_callback.c b/net/tcp/tcp_callback.c
index c717512..591cb78 100644
--- a/net/tcp/tcp_callback.c
+++ b/net/tcp/tcp_callback.c
@@ -96,7 +96,11 @@ tcp_data_event(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn,
#ifdef CONFIG_NET_STATISTICS
g_netstats.tcp.drop++;
#endif
- /* Clear the TCP_SNDACK bit so that no ACK will be sent */
+ /* Clear the TCP_SNDACK bit so that no ACK will be sent.
+ *
+ * Revisit: It might make more sense to send a dup ack
+ * to give a hint to the peer.
+ */
ret &= ~TCP_SNDACK;
}