You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/15 11:56:16 UTC
[GitHub] [dolphinscheduler] JinyLeeChina opened a new issue, #11970: [Feature][Dependence] Reform dependence mode
JinyLeeChina opened a new issue, #11970:
URL: https://github.com/apache/dolphinscheduler/issues/11970
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Present situation: The current dependency is on a single task and All. In fact, All depends on workflow, not all tasks
Planned reform:
1. The mode of relying on a single task remains unchanged. All is changed to rely on all tasks in the workflow, and a new type of workflow dependency is added.
2. The front end adds a radio box in the dependency area to select dependent tasks or workflows. If you select dependent tasks, the task selection box will be displayed. If you now rely on workflows, the task selection box will be hidden
3. For the backend, All is still 0 for the task code. When workflow is relied on, the corresponding task code can be represented by - 1 or other
----------
当前状况：当前的依赖是依赖单个任务和All，这里的All其实是依赖工作流，并不是依赖所有的任务
计划改造：
1、依赖单个任务的方式不变，All改造成依赖工作流中所有任务，新增一种类型依赖工作流。
2、前端在依赖的地方增加个单选框，选择依赖任务或者工作流，如果选择依赖任务，任务的选择框显示出来，如果现在依赖工作流，任务的选择框隐藏
3、对于后端，All对于的任务code还是0，依赖工作流时，对应的任务code可使用-1或其他表示
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guowei-su commented on issue #11970: [Feature][Dependence] Reform dependence mode
Posted by "guowei-su (via GitHub)" <gi...@apache.org>.
guowei-su commented on issue #11970:
URL: https://github.com/apache/dolphinscheduler/issues/11970#issuecomment-1687616734
Hi, I will contribute this feature.
The dependency mode for dependent node in dev branches will be modified.
- The logic of **Dependent on ALL** will be changed from **checking the workflow state** to **checking the state of all task instances in the workflow**.
- A new **Dependent on workflow** is added that is responsible for **checking the workflow state**.
- For compatibility with user history data, Constants.DEPENDENT_WORKFLOW_CODE will be assigned a value of 0, replacing the original Constants.DEPENDENT_ALL_TASK_CODE, and Constants.DEPENDENT_ALL_TASK_CODE will be assigned a value of -1.
I'll add a drop-down select box that controls the type of dependency to the front-end code to support this feature. The select box options include **Dependent on workflow** and **Dependent on task**. When Dependent on workflow is selected, it looks like the following image:
When Dependent on task is selected, as shown below:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][Dependence] Reform dependence mode [dolphinscheduler]
Posted by "JinyLeeChina (via GitHub)" <gi...@apache.org>.
JinyLeeChina closed issue #11970: [Feature][Dependence] Reform dependence mode
URL: https://github.com/apache/dolphinscheduler/issues/11970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11970: [Feature][Dependence] Reform dependence mode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11970:
URL: https://github.com/apache/dolphinscheduler/issues/11970#issuecomment-1248156856
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11970: [Feature][Dependence] Reform dependence mode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11970:
URL: https://github.com/apache/dolphinscheduler/issues/11970#issuecomment-1248156522
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Present situation: The current dependency is on a single task and All. In fact, All depends on workflow, not all tasks
Planned reform:
1. The mode of relying on a single task remains unchanged. All is changed to rely on all tasks in the workflow, and a new type of workflow dependency is added.
2. The front end adds a radio box in the dependency area to select dependent tasks or workflows. If you select dependent tasks, the task selection box will be displayed. If you now rely on workflows, the task selection box will be hidden
3. For the backend, All is still 0 for the task code. When workflow is relied on, the corresponding task code can be represented by - 1 or other
----------
当前状况：当前的依赖是依赖单个任务和All，这里的All其实是依赖工作流，并不是依赖所有的任务
计划改造：
1、依赖单个任务的方式不变，All改造成依赖工作流中所有任务，新增一种类型依赖工作流。
2、前端在依赖的地方增加个单选框，选择依赖任务或者工作流，如果选择依赖任务，任务的选择框显示出来，如果现在依赖工作流，任务的选择框隐藏
3、对于后端，All对于的任务code还是0，依赖工作流时，对应的任务code可使用-1或其他表示
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][Dependence] Reform dependence mode [dolphinscheduler]
Posted by "JinyLeeChina (via GitHub)" <gi...@apache.org>.
JinyLeeChina commented on issue #11970:
URL: https://github.com/apache/dolphinscheduler/issues/11970#issuecomment-1770455136
closed by #14824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org