You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:39:37 UTC

[GitHub] [skywalking] wu-sheng opened a new issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

wu-sheng opened a new issue #7943:
URL: https://github.com/apache/skywalking/issues/7943


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   I can see the OpenJDK 17 is available, please add this version for runtime verification.
   
   This doc should be updated as well accordingly, https://skywalking.apache.org/docs/main/latest/en/setup/backend/backend-setup/#requirements-and-default-settings
   
   ### Use case
   
   Just in case users choose latest LTS JDK 17 radically, even from our experiences, this seems not a recommended one.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020039657


   @kezhenxu94 `eclipse-temurin` is `adoptopenjdk`(https://adoptopenjdk.net/). I am thinking about whether we should adopt the latest temurin release. WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7943:
URL: https://github.com/apache/skywalking/issues/7943


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-951534926


   As adoptopenjdk has moved into Eclipse foundation, the latest image including 17 has been hosted https://hub.docker.com/_/eclipse-temurin?tab=tags&page=1&name=17


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020037179


   > I would like to help migrate the base docker images to `eclipse-temurin` ones.
   
   Not sure whether you are talking the same thing. @wu-sheng is asking for verification on Java 17 but @lujiajing1126 is asking for arm Docker support, FWIW we already have ARM Docker images for OAP https://github.com/apache/skywalking/pkgs/container/skywalking%2Foap
   
   Changing the base Docker image is not recommended IIRC, unless it's only for testing (E2E).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7943:
URL: https://github.com/apache/skywalking/issues/7943


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020047787


   > @kezhenxu94 `eclipse-temurin` is `adoptopenjdk`(https://adoptopenjdk.net/). I am thinking about whether we should adopt the latest temurin release. WDYT?
   
   If you mean test the OAP on latest temurin release and make the tests pass, I'm +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] lujiajing1126 edited a comment on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
lujiajing1126 edited a comment on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1018158282


   I would like to help migrate the base docker images to `eclipse-temurin` ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020054533


   @kezhenxu94 Notice this from https://hub.docker.com/_/adoptopenjdk
   
   ```markdown
   ## DEPRECATION NOTICE
   This image is officially deprecated in favor of the eclipse-temurin image, and will receive no further updates after 2021-08-01 (Aug 01, 2021). Please adjust your usage accordingly.
   ```
   
   The base image should be updated too. And JDK17 runtime could be considered if it doesn't break release process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] lujiajing1126 commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1018158282


   I would like to help migrate the docker images to `eclipse-temurin` ones.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng removed a comment on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng removed a comment on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-944888796


   After plugin test tool container and a new plugin(JDK17 compiling and runtime), this doc should be updated, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/readme/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020040142


   Another thing is, whether we should provide JDK17 runtime docker image on GitHub repo for testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020049377


   > Another thing is, whether we should provide JDK17 runtime docker image on GitHub repo for testing?
   
   I can add a step to push that image


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] lujiajing1126 commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-1020072849


   > > I would like to help migrate the base docker images to `eclipse-temurin` ones.
   > 
   > Not sure whether you are talking the same thing. @wu-sheng is asking for verification on Java 17 but @lujiajing1126 is asking for arm Docker support, FWIW we already have ARM Docker images for OAP https://github.com/apache/skywalking/pkgs/container/skywalking%2Foap
   > 
   > Changing the base Docker image is not recommended IIRC, unless it's only for testing (E2E).
   
   Yes. At the very beginning, I meant only the E2E parts.
   
   Then due to the deprecation warning from the https://hub.docker.com/_/adoptopenjdk repo mentioned by @wu-sheng, I suppose we should migrate all base images to the recommended ones built by `eclipse-temurin`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7943: [Feature] Add OpenJDK 17 (LTS) test for backend server runtime

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7943:
URL: https://github.com/apache/skywalking/issues/7943#issuecomment-944888796


   After plugin test tool container and a new plugin(JDK17 compiling and runtime), this doc should be updated, https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/readme/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org