[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7826: cpvm: Fix CPVM not releasing CPU after closing console

["GutoVeronezi (via GitHub)" <gi...@apache.org>]

GutoVeronezi commented on code in PR #7826:
URL: https://github.com/apache/cloudstack/pull/7826#discussion_r1293777831


##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java:
##########
@@ -113,25 +113,29 @@ public void run() {
                             if (client.isVncOverWebSocketConnectionOpen()) {
                                 updateFrontEndActivityTime();
                             }
-                            connectionAlive = client.isVncOverWebSocketConnectionAlive();
+                            connectionAlive = session.isOpen();

Review Comment:
   @weizhouapache 
   
   I did a quick test with VMware 7.0 U3; when the session times out on the VMware side, it closes the websocket and the resources on the CPVM are freed. 
   
   It would be good if others could try other use cases as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org