[jira] [Commented] (HBASE-9295) Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769689#comment-13769689 ] 

Ted Yu commented on HBASE-9295:
-------------------------------

Here is sample output where the tested patch omits comparator for TreeMap:
{code}
		    {color:red}-1 Anti-pattern{color}.  The patch appears to have anti-pattern :
             +      Map<byte[], Integer> kvCount = new TreeMap<byte[], Integer>();.
{code}
                
> Allow test-patch.sh to detect TreeMap keyed by byte[] which doesn't use proper comparator
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-9295
>                 URL: https://issues.apache.org/jira/browse/HBASE-9295
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0
>
>         Attachments: 9295-v1.txt
>
>
> There were two recent bug fixes (HBASE-9285 and HBASE-9238) for the case where the TreeMap keyed by byte[] doesn't use proper comparator:
> {code}
> new TreeMap<byte[], ...>()
> {code}
> test-patch.sh should be able to detect this situation and report accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira