You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "LiJie20190102 (via GitHub)" <gi...@apache.org> on 2024/08/06 09:36:19 UTC

[PR] AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error [ambari]

LiJie20190102 opened a new pull request, #3806:
URL: https://github.com/apache/ambari/pull/3806

   AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error
   
   ## What changes were proposed in this pull request?
   Resolve attribute dependency issues and avoid errors
   
   (Please fill in changes proposed in this fix)
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. Ex: unit tests, manual tests)
   (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #3806:
URL: https://github.com/apache/ambari/pull/3806#issuecomment-2272466405

   @LiJie20190102 Because many fixes cannot be covered by unit tests alone, if no screenshots or other information are provided in the "How to Test" section, it makes it very difficult for reviewers. I hope you can understand this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error [ambari]

Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #3806:
URL: https://github.com/apache/ambari/pull/3806#issuecomment-2272455802

   > This issue indeed exists. It was caused by the merge of this PR: #3656. When testing the Ambari agent installation of components locally, it results in an error. Thank you for your fix. It would be even better if you could attach screenshots of the error message before the fix and the log output after the fix.
   
   I can't find the screenshot anymore. I think this issue can be resolved without the need for a screenshot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error [ambari]

Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #3806:
URL: https://github.com/apache/ambari/pull/3806#issuecomment-2272468870

   > @LiJie20190102 Because many fixes cannot be covered by unit tests alone, if no screenshots or other information are provided in the "How to Test" section, it makes it very difficult for reviewers. I hope you can understand this.
   
   I completely understand what you mean, and next time I will keep the relevant screenshots


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error [ambari]

Posted by "LiJie20190102 (via GitHub)" <gi...@apache.org>.
LiJie20190102 commented on PR #3806:
URL: https://github.com/apache/ambari/pull/3806#issuecomment-2271360985

   @JiaLiangC Could you help review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26111: Adjust code sequence in ‘ambari-agent/src/main/python/ambari_agent/InitializerModule.py’ to prevent code error [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC merged PR #3806:
URL: https://github.com/apache/ambari/pull/3806


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org