You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/30 12:02:58 UTC
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #382: feat: enable MTLS between dashboard and etcd
tokers commented on code in PR #382:
URL: https://github.com/apache/apisix-helm-chart/pull/382#discussion_r1008842114
##########
charts/apisix-dashboard/README.md:
##########
@@ -67,17 +67,22 @@ The following tables lists the configurable parameters of the apisix-dashboard c
| Name | Description | Value |
| ------------------------------------ | ----------------------------------------------------------------------------------------- | --------------- |
| `config.conf.listen.host` | The address on which the `Manager API` should listen. The default value is 0.0.0.0, if want to specify, please enable it. This value accepts IPv4, IPv6, and hostname. | `0.0.0.0` |
-| `config.conf.listen.port` | The port on which the `Manager API` should listen. | `9000` |
+| `config.conf.listen.port` | The port on which the `Manager API` should listen. | `9000` |
| `config.authentication.secert` | Secret for jwt token generation | `secert` |
-| `config.authentication.expireTime` | JWT token expire time, in second | `3600` |
-| `config.authentication.users` | Specifies username and password for login `manager api`. | `[{username: admin, password: admin}]` |
-| `config.conf.etcd.endpoints` | Supports defining multiple etcd host addresses for an etcd cluster | `apisix-etcd:2379` |
-| `config.conf.etcd.prefix` | Apache APISIX config's prefix in etcd, /apisix by default | `/apisix` |
-| `config.conf.etcd.username` | Specifies etcd basic auth username if enable etcd auth | `~` |
-| `config.conf.etcd.password` | Specifies etcd basic auth password if enable etcd auth | `~` |
-| `config.conf.log.accessLog.filePath` | Access log path | `/dev/stdout` |
-| `config.conf.log.errorLog.filePath` | Error log path | `/dev/stderr` |
-| `config.conf.log.errorLog.level` | Error log level. Supports levels, lower to higher: debug, info, warn, error, panic, fatal | `warn` |
+| `config.authentication.expireTime` | JWT token expire time, in second | `3600` |
+| `config.authentication.users` | Specifies username and password for login `manager api`. | `[{username: admin, password: admin}]` |
+| `config.conf.etcd.endpoints` | Supports defining multiple etcd host addresses for an etcd cluster | `apisix-etcd:2379` |
+| `config.conf.etcd.prefix` | Apache APISIX config's prefix in etcd, /apisix by default | `/apisix` |
+| `config.conf.etcd.username` | Specifies etcd basic auth username if enable etcd auth | `~` |
+| `config.conf.etcd.password` | Specifies etcd basic auth password if enable etcd auth | `~` |
+| `config.conf.etcd.mtls.enabled` | Enable MTLS option when connecting to an etcd cluster with TLS enabled | `false` |
+| `config.conf.etcd.mtls.existingSecret` | Name of existing secret that contains certs for TLS authentication | `""` |
+| `config.conf.etcd.mtls.caFile` | Key of CA file in secret | `ca.crt` |
Review Comment:
This field will also be required even if we don't enable mTLS, i.e., just the simple TLS. I prefer to call the field `mtls` to `tls`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org