You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/03/03 17:14:49 UTC
Review Request 72187: Fixed build on platforms not treating
initializer_list as literal.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72187/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Benjamin Mahler.
Bugs: MESOS-10056
https://issues.apache.org/jira/browse/MESOS-10056
Repository: mesos
Description
-------
Fixed build on platforms not treating initializer_list<enum> as literal.
Diffs
-----
src/master/framework.cpp 7e46469dc727ea6f38ca6331b649b3c80e343171
Diff: https://reviews.apache.org/r/72187/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72187: Fixed build on platforms not treating
initializer_list as literal.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72187/#review219739
-----------------------------------------------------------
Ship it!
Isn't this a static non-POD (which we ban per the google style guide)? If so, then maybe use a pointer or make it a function?
- Benjamin Mahler
On March 3, 2020, 5:14 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72187/
> -----------------------------------------------------------
>
> (Updated March 3, 2020, 5:14 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
>
>
> Bugs: MESOS-10056
> https://issues.apache.org/jira/browse/MESOS-10056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed build on platforms not treating initializer_list<enum> as literal.
>
>
> Diffs
> -----
>
> src/master/framework.cpp 7e46469dc727ea6f38ca6331b649b3c80e343171
>
>
> Diff: https://reviews.apache.org/r/72187/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72187: Fixed build on platforms not treating
initializer_list as literal.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72187/#review219743
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72187]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On March 3, 2020, 8:14 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72187/
> -----------------------------------------------------------
>
> (Updated March 3, 2020, 8:14 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
>
>
> Bugs: MESOS-10056
> https://issues.apache.org/jira/browse/MESOS-10056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed build on platforms not treating initializer_list<enum> as literal.
>
>
> Diffs
> -----
>
> src/master/framework.cpp 7e46469dc727ea6f38ca6331b649b3c80e343171
>
>
> Diff: https://reviews.apache.org/r/72187/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72187: Fixed build on platforms not treating
initializer_list as literal.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72187/#review219741
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On March 3, 2020, 8:14 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72187/
> -----------------------------------------------------------
>
> (Updated March 3, 2020, 8:14 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Benjamin Mahler.
>
>
> Bugs: MESOS-10056
> https://issues.apache.org/jira/browse/MESOS-10056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed build on platforms not treating initializer_list<enum> as literal.
>
>
> Diffs
> -----
>
> src/master/framework.cpp 7e46469dc727ea6f38ca6331b649b3c80e343171
>
>
> Diff: https://reviews.apache.org/r/72187/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72187: Fixed build on platforms not treating
initializer_list as literal.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72187/
-----------------------------------------------------------
(Updated March 3, 2020, 8:14 p.m.)
Review request for mesos, Andrei Budnik and Benjamin Mahler.
Changes
-------
Moved as a brace-init-list into `createObjectApprovers(...)` to avoid non-pod global static and other initializer_list lifetime issues.
Bugs: MESOS-10056
https://issues.apache.org/jira/browse/MESOS-10056
Repository: mesos
Description
-------
Fixed build on platforms not treating initializer_list<enum> as literal.
Diffs (updated)
-----
src/master/framework.cpp 7e46469dc727ea6f38ca6331b649b3c80e343171
Diff: https://reviews.apache.org/r/72187/diff/2/
Changes: https://reviews.apache.org/r/72187/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko