You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Krisztian Szucs (JIRA)" <ji...@apache.org> on 2018/10/17 14:42:00 UTC

[jira] [Resolved] (ARROW-3540) [Rust] Incorporate BooleanArray into PrimitiveArray

     [ https://issues.apache.org/jira/browse/ARROW-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Krisztian Szucs resolved ARROW-3540.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.12.0

Issue resolved by pull request 2778
[https://github.com/apache/arrow/pull/2778]

> [Rust] Incorporate BooleanArray into PrimitiveArray
> ---------------------------------------------------
>
>                 Key: ARROW-3540
>                 URL: https://issues.apache.org/jira/browse/ARROW-3540
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: Rust
>            Reporter: Paddy Horan
>            Assignee: Paddy Horan
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.12.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently we have a specific implementation for `BooleanArray` (bit-packing), but due to the `ArrowPrimitiveType` trait which we use as a trait bound in many places `PrimitiveArray<bool>` is still a valid type.  `make_array` actually uses `PrimitiveArray<bool>` which may be a bug but would be fixed by this issue anyway.
> I propose move the implementation of `BooleanArray` into `PrimitiveArray<bool>`, this would allow us to use the `ArrayPrimitiveType` trait as a bound more consistently.  i.e. `PrimitiveArrayBuilder<T>` could return `PrimitiveArray<T>` instead of having a separate `BooleanArrayBuilder`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)