You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Anita Jebaraj <aj...@us.ibm.com> on 2017/05/01 22:15:48 UTC
Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
Bugs: AMBARI-20904
https://issues.apache.org/jira/browse/AMBARI-20904
Repository: ambari
Description
-------
Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
Diff: https://reviews.apache.org/r/58894/diff/1/
Testing
-------
Tested manually
File Attachments
----------------
ClearFilters
https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
Thanks,
Anita Jebaraj
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by Anita Jebaraj <aj...@us.ibm.com>.
> On May 3, 2017, 10:30 a.m., belliraj hb wrote:
> > I guess "clear filter" takes lot of space. I think clear filter should be a simpler icon (may be a X) and it should be before refresh.
Thank you for the comments, I have updated the icon, please review the new patch
- Anita
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review173719
-----------------------------------------------------------
On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 7:09 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/2/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review173719
-----------------------------------------------------------
I guess "clear filter" takes lot of space. I think clear filter should be a simpler icon (may be a X) and it should be before refresh.
- belliraj hb
On May 1, 2017, 10:15 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 10:15 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/1/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review173941
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On May 1, 2017, 10:15 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 10:15 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/1/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by Anita Jebaraj <aj...@us.ibm.com>.
> On May 5, 2017, 5:10 a.m., belliraj hb wrote:
> > Ship It!
can you please help in pushing the changes, thanks in advance
- Anita
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174001
-----------------------------------------------------------
On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 7:09 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/2/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174001
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 7:09 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/2/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by Anita Jebaraj <aj...@us.ibm.com>.
> On May 12, 2017, 6:57 a.m., venkat sairam wrote:
> > When we enter some random text instead of selecting "tagsinput" option, the text is not cleared even after clicking clear filters button.
> > Please handle this use case too.
Hi, I have updated the patch with this usecase, please review it. Thanks in advance
- Anita
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174766
-----------------------------------------------------------
On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 7:09 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/3/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174766
-----------------------------------------------------------
When we enter some random text instead of selecting "tagsinput" option, the text is not cleared even after clicking clear filters button.
Please handle this use case too.
- venkat sairam
On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 7:09 p.m.)
>
>
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
>
>
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
>
>
> Diff: https://reviews.apache.org/r/58894/diff/2/
>
>
> Testing
> -------
>
> Tested manually
>
>
> File Attachments
> ----------------
>
> ClearFilters
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
>
>
> Thanks,
>
> Anita Jebaraj
>
>
Re: Review Request 58894: WFM: Include an option to clear filters in
workflow dashboard
Posted by Anita Jebaraj <aj...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/
-----------------------------------------------------------
(Updated May 4, 2017, 7:09 p.m.)
Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
Bugs: AMBARI-20904
https://issues.apache.org/jira/browse/AMBARI-20904
Repository: ambari
Description
-------
Currently the filters can be cleared only manually by removing the contents, having a button to clear the filters on one click would be helpful.
Diffs (updated)
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 4bfb5fa
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs b9c6029
Diff: https://reviews.apache.org/r/58894/diff/2/
Changes: https://reviews.apache.org/r/58894/diff/1-2/
Testing
-------
Tested manually
File Attachments
----------------
ClearFilters
https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
Thanks,
Anita Jebaraj