[jira] [Resolved] (OAK-6177) AddMembersTest should add unique items to groups

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu resolved OAK-6177.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8
                   1.7.0

as suggested, I added dedicated bench {{AddUniqueMembersTest}}
the difference is pretty big between the 2 stats:

{noformat}
# AddMembersTest                   C     min     10%     50%     90%     max       N 
Oak-Segment-Tar                    1       0       0       0       0       6  714905
# AddUniqueMembersTest             C     min     10%     50%     90%     max       N 
Oak-Segment-Tar                    1       5       9      29     149     255    1060
{noformat}

fixed with rev http://svn.apache.org/viewvc?rev=1794589&view=rev

> AddMembersTest should add unique items to groups
> ------------------------------------------------
>
>                 Key: OAK-6177
>                 URL: https://issues.apache.org/jira/browse/OAK-6177
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: benchmarks
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-6177.patch
>
>
> In the current setup the {{AddMembersTest}} benchmark exhausts unique user ids and quite quickly starts adding existing items to the same groups reducing the usefulness of the profiling results (the Group code bails early for existing members).
> I think we should make this benchmark add only unique items. [~anchela] what do you think?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)