You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/15 05:12:15 UTC
[GitHub] [singa] nudles opened a new pull request #795: Update the Github Workflow for uploading conda packages
nudles opened a new pull request #795:
URL: https://github.com/apache/singa/pull/795
The anaconda upload token is stored as a secret on github.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] nudles commented on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
nudles commented on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-693783194
>
>
> I think it will be better to create a new separate workflow for publishing conda packages. In the conda package workflow, the build should not use ENABLE_TEST unless it is building a dev package for developers not a normal package for users. This will make the built code faster because it can use compiler optimizations which are not available in test mode and smaller because it does not contain the debug information.
>
> The packaging workflow (for conda, pypi, debian, docker, etc) should not contain the code coverage steps because (1) the code is usually not built with test enabled. (2) there is no need to upload a new coverage report for the same python test cases unless there are special test cases for the the package process itself.
>
> The packaging workflow may not run with each pull request or merge on the dev branch, but they can run periodically every week for example or only when merging with the master branch.
Currently,
1. CPP test is done by native-macos and native-ubuntu for every PR, for which ENABLE_TEST is on.
2. Python test is done by conda for every PR, for which ENABLE_TEST is off.
3. conda package uploading is disabled on apache/singa because we cannot set the secret key for the uploading token.
I am fine to disable code coverage for 2 and 3, i.e., conda.yaml.
How should we disable it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] moazreyad commented on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
moazreyad commented on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-694674537
> conda package uploading is disabled on apache/singa because we cannot set the secret key for the uploading token
Why we cannot set the secret key? Can we [ask INFRA to add the key](https://github.com/apache/singa/pull/790#issuecomment-690927600) as discussed in #790?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] chrishkchris merged pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
chrishkchris merged pull request #795:
URL: https://github.com/apache/singa/pull/795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-692470102
# [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=h1) Report
> Merging [#795](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/0d79d526a3e7fcb621614da2e13882a06cdf6634?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #795 +/- ##
==========================================
- Coverage 70.06% 65.09% -4.98%
==========================================
Files 100 86 -14
Lines 11568 4804 -6764
==========================================
- Hits 8105 3127 -4978
+ Misses 3463 1677 -1786
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <ø> (-0.03%)` | :arrow_down: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [utils.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | | |
| [autograd.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | | |
| [layer.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | | |
| [device.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | | |
| [model.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | | |
| ... and [6 more](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=footer). Last update [0d79d52...7b5a0ab](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-692470102
# [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=h1) Report
> Merging [#795](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/0d79d526a3e7fcb621614da2e13882a06cdf6634?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #795 +/- ##
==========================================
- Coverage 70.06% 65.09% -4.98%
==========================================
Files 100 86 -14
Lines 11568 4804 -6764
==========================================
- Hits 8105 3127 -4978
+ Misses 3463 1677 -1786
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <ø> (-0.03%)` | :arrow_down: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | | |
| [sonnx.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | | |
| [opt.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-b3B0LnB5) | | |
| [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | | |
| [data.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | | |
| [model.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | | |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| ... and [6 more](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=footer). Last update [0d79d52...7b5a0ab](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] edited a comment on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-692470102
# [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=h1) Report
> Merging [#795](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/0d79d526a3e7fcb621614da2e13882a06cdf6634?el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #795 +/- ##
==========================================
- Coverage 70.06% 70.05% -0.02%
==========================================
Files 100 100
Lines 11568 11573 +5
==========================================
+ Hits 8105 8107 +2
- Misses 3463 3466 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <ø> (-0.03%)` | :arrow_down: |
| #singa-python | `73.57% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <0.00%> (+0.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=footer). Last update [0d79d52...7b5a0ab](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] moazreyad commented on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
moazreyad commented on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-692821265
I think it will be better to create a new separate workflow for publishing conda packages. In the conda package workflow, the build should not use ENABLE_TEST unless it is building a dev package for developers not a normal package for users. This will make the built code faster because it can use compiler optimizations which are not available in test mode and smaller because it does not contain the debug information.
The packaging workflow (for conda, pypi, debian, docker, etc) should not contain the code coverage steps because (1) the code is usually not built with test enabled. (2) there is no need to upload a new coverage report for the same python test cases unless there are special test cases for the the package process itself.
The packaging workflow may not run with each pull request or merge on the dev branch, but they can run periodically every week for example or only when merging with the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [singa] codecov[bot] commented on pull request #795: Update the Github Workflow for uploading conda packages
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #795:
URL: https://github.com/apache/singa/pull/795#issuecomment-692470102
# [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=h1) Report
> Merging [#795](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/0d79d526a3e7fcb621614da2e13882a06cdf6634?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #795 +/- ##
==========================================
- Coverage 70.06% 65.09% -4.98%
==========================================
Files 100 86 -14
Lines 11568 4804 -6764
==========================================
- Hits 8105 3127 -4978
+ Misses 3463 1677 -1786
```
| Flag | Coverage Δ | |
|---|---|---|
| #singa-cpp | `65.09% <ø> (-0.03%)` | :arrow_down: |
| #singa-python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
| [tensor.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | | |
| [initializer.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW5pdGlhbGl6ZXIucHk=) | | |
| [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | | |
| [data.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | | |
| [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | | |
| [device.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
| [layer.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | | |
| [utils.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | | |
| [image\_tool.py](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
| ... and [6 more](https://codecov.io/gh/apache/singa/pull/795/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=footer). Last update [0d79d52...233eb33](https://codecov.io/gh/apache/singa/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org