You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/12/18 10:36:05 UTC
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #400: chore(dist): replace profile id & unify the dependencies/plugins
imbajin commented on code in PR #400:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/400#discussion_r1051572834
##########
hugegraph-tools/pom.xml:
##########
@@ -297,8 +276,8 @@
<plugin>
<artifactId>maven-release-plugin</artifactId>
<configuration>
- <!-- Pass these arguments to the deploy plugin. -->
- <arguments>-Prelease</arguments>
+ <!-- Pass these arguments to the deployment plugin. -->
+ <arguments>-Papache-release</arguments>
Review Comment:
the profile `id` refers & keep the same with the parent `apache` pom:
https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L378
##########
hugegraph-tools/pom.xml:
##########
@@ -297,8 +276,8 @@
<plugin>
<artifactId>maven-release-plugin</artifactId>
<configuration>
- <!-- Pass these arguments to the deploy plugin. -->
- <arguments>-Prelease</arguments>
+ <!-- Pass these arguments to the deployment plugin. -->
+ <arguments>-Papache-release</arguments>
Review Comment:
the profile `id` refers & keep the same with the parent `apache` pom:
https://github.com/apache/maven-apache-parent/blob/99592e229c20f079c1998875e5c24556d217b491/pom.xml#L378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org