You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/02/06 14:14:50 UTC
[GitHub] [mynewt-nimble] xiaoxiang781216 opened a new pull request, #1459: Fix the compiler warning on NuttX
xiaoxiang781216 opened a new pull request, #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459
Report here: https://github.com/apache/nuttx-apps/actions/runs/4102723052/jobs/7076100328
- Fix ble_hci_socket.c:359:5: warning: implicit declaration of function ‘ble_hci_trans_buf_free’
- Fix SYSINIT_PANIC_ASSERT_MSG refinition warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc merged pull request #1459: Fix the compiler warning on NuttX
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] xiaoxiang781216 commented on pull request #1459: Fix the compiler warning on NuttX
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459#issuecomment-1422585892
The patch pass CI now, could you merge it? https://github.com/apache/nuttx-apps/pull/1543 dpends on this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] xiaoxiang781216 commented on pull request #1459: Fix the compiler warning on NuttX
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459#issuecomment-1422622754
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1459: Fix the compiler warning on NuttX
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459#issuecomment-1422618025
Could you follow commit conventions? (prefixes, limit commit subject to 72 characters) eg:
"nimble/transport: Fix compilation warning in socket transport"
"porting: Fix SYSINIT_PANIC_ASSERT_MSG redefinition"
we don't have very strict rules for commit messages but would be good to follow more-or-less what is in history. You can check that with "git log -- PATH_TO_FILE_OR_FOLDER"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] xiaoxiang781216 commented on pull request #1459: Fix the compiler warning on NuttX
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459#issuecomment-1419408407
@sjanc do you know why the CI fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #1459: Fix the compiler warning on NuttX
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #1459:
URL: https://github.com/apache/mynewt-nimble/pull/1459#issuecomment-1419572843
> @sjanc do you know why the CI fail?
looks like some networking issues in github actions, I've restarted failed jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org