[jira] [Comment Edited] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

["Noble Paul (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141874#comment-17141874 ] 

Noble Paul edited comment on SOLR-14579 at 6/22/20, 10:15 AM:
--------------------------------------------------------------

We can't really trust that it's going to optimize it for sure

Solr is full of inefficient code. We don't have to add more of it. if possible we should work towards eliminating them


was (Author: noble.paul):
Our code still compiles with java 8 for the current releases. It's a very bad idea to use these lambdas. Readability is not much better if we do not use that static variable. 

Solr is full of inefficient code. We don't have to add more of it. if possible we should work towards eliminating them

> Remove SolrJ 'Utils' generic map functions
> ------------------------------------------
>
>                 Key: SOLR-14579
>                 URL: https://issues.apache.org/jira/browse/SOLR-14579
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (9.0)
>            Reporter: Megan Carey
>            Assignee: Noble Paul
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Remove the map functions like `NEW_HASHMAP_FUN` from the Utils class in solrj module to reduce warnings and improve code quality.
> [https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/common/util/Utils.java#L92]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org