You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Senthil Kumaran S <se...@collab.net> on 2008/08/22 08:41:07 UTC

[PATCH] Fix some build warnings

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I am attaching a patch along with this email which fixes some compiler warnings
shown below:

<snip>
../subversion/libsvn_fs_fs/fs_fs.c: In function 'read_rep_offsets':
../subversion/libsvn_fs_fs/fs_fs.c:1602: warning: unused variable 'i'
../subversion/tests/libsvn_fs/fs-test.c: In function ‘verify_checksum’:
../subversion/tests/libsvn_fs/fs-test.c:4405: warning: passing argument 1 of
‘svn_fs_file_checksum’ from incompatible pointer type
</snip>

[[[
Fix some build warnings.

* subversion/tests/libsvn_fs/fs-test.c
  (verify_checksum): Pass the correct pointer type of 'actual_checksum'
   to 'svn_fs_file_checksum'.

* subversion/libsvn_fs_fs/fs_fs.c
  (read_rep_offsets): Remove unused variable 'i'.

Patch by: stylesen
]]]

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIrnuh9o1G+2zNQDgRAooWAJ9FUGbYoL1/4st8pnCKTuCGG0hQigCfeRPb
63c2LB0+7sGa5kr7L5/CAOM=
=zY1Q
-----END PGP SIGNATURE-----

Re: [PATCH] Fix some build warnings

Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Senthil Kumaran S wrote:
> ../subversion/tests/libsvn_fs/fs-test.c: In function ‘verify_checksum’:
> ../subversion/tests/libsvn_fs/fs-test.c:4405: warning: passing argument 1 of
> ‘svn_fs_file_checksum’ from incompatible pointer type

The above causes a test to fail in fs-test:

<snip>
FAIL:  lt-fs-test 29: test checksums
make: *** [check] Error 1
</snip>

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIroG59o1G+2zNQDgRAs75AJ9ZR2Xvwt3NJN8pHMrEOr8C/GIfCgCgkumf
GI1gwZqBVYJlknOKoJlkA7A=
=MMmt
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix some build warnings

Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arfrever Frehtes Taifersar Arahesis wrote:
>> [[[
>> Fix some build warnings.
>>
>> * subversion/tests/libsvn_fs/fs-test.c
>>   (verify_checksum): Pass the correct pointer type of 'actual_checksum'
>>    to 'svn_fs_file_checksum'.
> 
>    to svn_fs_file_checksum().
> 
>> * subversion/libsvn_fs_fs/fs_fs.c
>>   (read_rep_offsets): Remove unused variable 'i'.
>>
>> Patch by: stylesen
>> ]]]
> 
> +1 to commit.

Committed in r32631.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIrofX9o1G+2zNQDgRAl/MAJ9hvRGnVaRd9PzmPYT/Y6WrxdgErACfZCyN
kLGRkZIk5gFphOMm8DzpqaE=
=pe4r
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix some build warnings

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-08-22 10:41:07 Senthil Kumaran S napisał(a):
> Hi,
> 
> I am attaching a patch along with this email which fixes some compiler warnings
> shown below:
> 
> <snip>
> ../subversion/libsvn_fs_fs/fs_fs.c: In function 'read_rep_offsets':
> ../subversion/libsvn_fs_fs/fs_fs.c:1602: warning: unused variable 'i'
> ../subversion/tests/libsvn_fs/fs-test.c: In function ‘verify_checksum’:
> ../subversion/tests/libsvn_fs/fs-test.c:4405: warning: passing argument 1 of
> ‘svn_fs_file_checksum’ from incompatible pointer type
> </snip>
> 
> [[[
> Fix some build warnings.
> 
> * subversion/tests/libsvn_fs/fs-test.c
>   (verify_checksum): Pass the correct pointer type of 'actual_checksum'
>    to 'svn_fs_file_checksum'.

   to svn_fs_file_checksum().

> 
> * subversion/libsvn_fs_fs/fs_fs.c
>   (read_rep_offsets): Remove unused variable 'i'.
> 
> Patch by: stylesen
> ]]]

+1 to commit.

-- 
Arfrever Frehtes Taifersar Arahesis