[GitHub] sohami commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI
URL: https://github.com/apache/drill/pull/1379#discussion_r202250119
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
 ##########
 @@ -83,12 +83,17 @@ public QueryResult run(final WorkManager workManager, final WebUserConnection we
     float usagePercent = getHeapUsage();
 
     // Wait until the query execution is complete or there is error submitting the query
-    logger.debug("Wait until the query execution is complete or there is error submitting the query");
+    if (logger.isDebugEnabled()) {
+      logger.debug("Wait until the query execution is complete or there is error submitting the query");
+    }
     do {
       try {
-        isComplete = webUserConnection.await(TimeUnit.SECONDS.toMillis(1)); /*periodically timeout to check heap*/
-      } catch (Exception e) { }
-
+        isComplete = webUserConnection.timedWait(TimeUnit.SECONDS.toMillis(1)); /*periodically timeout 1sec to check heap */
 
 Review comment:
   Actually you don't need this `timedWait` method. You can still use same `await(timeout)` as you were using earlier. But outside while loop you can do below check to get the exception in error condition. Check [here](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java#L158) 
   
   ```
   // check if query completed with exception
   if (isComplete && webUserConnection.getError() != null) {
         throw new UserRemoteException(webUserConnection.getError());
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services