You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "baerwang (via GitHub)" <gi...@apache.org> on 2023/12/12 08:44:11 UTC
[PR] feat: metadata port reuse [dubbo-go]
baerwang opened a new pull request, #2538:
URL: https://github.com/apache/dubbo-go/pull/2538
#2537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853314480
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d204c4e`)](https://app.codecov.io/gh/apache/dubbo-go/commit/d204c4ef491dd22c58c4fd2e0a30e0f9d4e57715?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.91% compared to head [(`a71a8bd`)](https://app.codecov.io/gh/apache/dubbo-go/pull/2538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 44.80%.
> :exclamation: Current head a71a8bd differs from pull request most recent head e3af8f5. Consider uploading reports for the commit e3af8f5 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## release-3.1 #2538 +/- ##
===============================================
- Coverage 44.91% 44.80% -0.11%
===============================================
Files 270 270
Lines 18354 18356 +2
===============================================
- Hits 8243 8224 -19
- Misses 9225 9249 +24
+ Partials 886 883 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/2538?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "zhaoyunxing92 (via GitHub)" <gi...@apache.org>.
zhaoyunxing92 commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1436457239
##########
config/application_config.go:
##########
@@ -37,8 +37,9 @@ type ApplicationConfig struct {
Owner string `default:"dubbo-go" yaml:"owner" json:"owner,omitempty" property:"owner"`
Environment string `yaml:"environment" json:"environment,omitempty" property:"environment"`
// the metadata type. remote or local
- MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
- Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
+ Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataServicePort int `yaml:"metadata_service_port" json:"metadata_service_port,omitempty" property:"metadata_service_port"`
Review Comment:
cofig use underline replaces horizontal line eg: `metadata-service-port `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853346629
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1426064757
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
use default port triple protocol for fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1851597263
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2538) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2538&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424804592
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +61,17 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetProtocolsInstance()[constant.DefaultProtocol]
Review Comment:
We also need to add the metdata port parameter to the application_config to align with the java side,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1851545802
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2538) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2538&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424995606
##########
config/application_config.go:
##########
@@ -37,8 +37,9 @@ type ApplicationConfig struct {
Owner string `default:"dubbo-go" yaml:"owner" json:"owner,omitempty" property:"owner"`
Environment string `yaml:"environment" json:"environment,omitempty" property:"environment"`
// the metadata type. remote or local
- MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
- Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
+ Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataServicePort int `default:"20001" yaml:"metadata_service_port" json:"metadata_service_port,omitempty" property:"metadata_service_port"`
Review Comment:
should not set a default value, when use it you don't known is user set it or default value used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424995606
##########
config/application_config.go:
##########
@@ -37,8 +37,9 @@ type ApplicationConfig struct {
Owner string `default:"dubbo-go" yaml:"owner" json:"owner,omitempty" property:"owner"`
Environment string `yaml:"environment" json:"environment,omitempty" property:"environment"`
// the metadata type. remote or local
- MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
- Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
+ Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataServicePort int `default:"20001" yaml:"metadata_service_port" json:"metadata_service_port,omitempty" property:"metadata_service_port"`
Review Comment:
should not set a default value, when use it you don't know is user set it or default value used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853456952
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1427596984
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
https://github.com/apache/dubbo-go/actions/runs/7203720804/job/19624025841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424999293
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
since we want reuse dubbo protocol port, I think the priority should be
1. MetadataServicePort
2. dubbo protocol port
3. default dubbo protocol port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853202721
Please commit to Branch 3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1436508255
##########
config/application_config.go:
##########
@@ -37,8 +37,9 @@ type ApplicationConfig struct {
Owner string `default:"dubbo-go" yaml:"owner" json:"owner,omitempty" property:"owner"`
Environment string `yaml:"environment" json:"environment,omitempty" property:"environment"`
// the metadata type. remote or local
- MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
- Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
+ Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataServicePort int `yaml:"metadata-service-port" json:"metadata_service_port,omitempty" property:"metadata_service_port"`
Review Comment:
Keep all tag consistent
##########
config/application_config.go:
##########
@@ -37,8 +37,9 @@ type ApplicationConfig struct {
Owner string `default:"dubbo-go" yaml:"owner" json:"owner,omitempty" property:"owner"`
Environment string `yaml:"environment" json:"environment,omitempty" property:"environment"`
// the metadata type. remote or local
- MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
- Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataType string `default:"local" yaml:"metadata-type" json:"metadataType,omitempty" property:"metadataType"`
+ Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ MetadataServicePort int `yaml:"metadata-service-port" json:"metadata_service_port,omitempty" property:"metadata_service_port"`
Review Comment:
This field uses string to be consistent with other port fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853436794
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1426205874
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
use default port,ci fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424999293
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
since we want reuse dubbo protocol port, I think the priority should be
1. MetadataServicePort
2. dubbo protocol port
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
since we want reuse dubbo protocol port, I think the priority should be
1. MetadataServicePort
2. dubbo protocol port user set or default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1855019775
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424949065
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
Review Comment:
If the user sets the MetadataServicePort, should we use that port?
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
Review Comment:
If the user sets the MetadataServicePort, should we use that port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1427590958
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
> use default port,ci fail
why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1869586909
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang closed pull request #2538: feat: metadata port reuse
URL: https://github.com/apache/dubbo-go/pull/2538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1871094836
https://github.com/apache/dubbo-go/pull/2548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1854972199
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424802394
##########
config/protocol_config.go:
##########
@@ -45,6 +45,9 @@ func (ProtocolConfig) Prefix() string {
}
func GetProtocolsInstance() map[string]*ProtocolConfig {
+ if err := check(); err == nil && rootConfig.Protocols != nil {
+ return rootConfig.Protocols
+ }
Review Comment:
no need here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853369231
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424968708
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
consistent with java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424979498
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
Adding a default port to the current policy causes CI failures, need delete default port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1869628048
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424979498
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
Adding a default port to the current policy causes CI failures, need delete default port or change default port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424988448
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
default port cause ci fail ,link: https://github.com/apache/dubbo-go/actions/runs/7191807715/job/19588269066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1426064757
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
use default port triple protocol for fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424803713
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +61,17 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetProtocolsInstance()[constant.DefaultProtocol]
Review Comment:
can use `config.GetRootConfig().Protocols[constant.DefaultProtocol]` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424979498
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
Adding a default port to the current policy causes CI failures, need delete default port or change default port?
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
default port cause ci fail ,link: https://github.com/apache/dubbo-go/actions/runs/7191807715/job/19588269066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424999293
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
since we want reuse dubbo protocol port, I think the priority should be
1. MetadataServicePort
2. dubbo protocol port set by user or default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1429456239
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
please create a new branch to show how you use default port,I want to know why ci failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1431460121
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
https://github.com/apache/dubbo-go/commit/d08bf0f07367d307ae3a8e9f5b49885643b94757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853349002
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1855011692
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#issuecomment-1853303536
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2538&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2538)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424950207
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
If the user sets the MetadataServicePort, should we use that port?
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
If the user sets the MetadataServicePort, should we use that port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424949065
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
Review Comment:
If the user sets the MetadataServicePort, should we use that port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: metadata port reuse [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2538:
URL: https://github.com/apache/dubbo-go/pull/2538#discussion_r1424999293
##########
metadata/service/exporter/configurable/exporter.go:
##########
@@ -61,12 +62,19 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
version, _ := exporter.metadataService.Version()
exporter.lock.Lock()
defer exporter.lock.Unlock()
+
+ protocolConfig, ok := config.GetRootConfig().Protocols[constant.DefaultProtocol]
+ if !ok {
+ protocolConfig = config.NewProtocolConfigBuilder().
+ SetName(constant.DefaultProtocol).
+ SetPort(strconv.Itoa(config.GetApplicationConfig().MetadataServicePort)).
+ Build()
+ }
Review Comment:
since we want reuse dubbo protocol port, I think the priority should be
1. MetadataServicePort
2. dubbo protocol port set by user
3. default dubbo protocol port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org