You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Henry Saginor (JIRA)" <ji...@apache.org> on 2012/11/21 02:42:58 UTC

[jira] [Created] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Henry Saginor created FELIX-3770:
------------------------------------

             Summary: Upgrade jquery-ui to 1.9.1
                 Key: FELIX-3770
                 URL: https://issues.apache.org/jira/browse/FELIX-3770
             Project: Felix
          Issue Type: New Feature
          Components: Web Console
            Reporter: Henry Saginor


It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved FELIX-3770.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: webconsole-4.0.2
         Assignee: Felix Meschberger

Applied the patch slightly modified in Rev. 1416228.

  * Use minified versions of JQuery und JQuery UI
  * Only use single minified jquery-ui.css file
  * Added debug profile build embedding non-minified versions of JQuery and JQuery UI as well as of the JQuery UI CSS files
                
> Upgrade jquery-ui to 1.9.1
> --------------------------
>
>                 Key: FELIX-3770
>                 URL: https://issues.apache.org/jira/browse/FELIX-3770
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Assignee: Felix Meschberger
>             Fix For: webconsole-4.0.2
>
>         Attachments: FELIX-3770.tar.gz, main_header.html.patch.txt
>
>
> It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508323#comment-13508323 ] 

Felix Meschberger edited comment on FELIX-3770 at 12/2/12 6:52 PM:
-------------------------------------------------------------------

Thank you very much for the update. I have applied the patch slightly modified in Rev. 1416228.

  * Use minified versions of JQuery und JQuery UI
  * Only use single minified jquery-ui.css file
  * Added debug profile build embedding non-minified versions of JQuery and JQuery UI as well as of the JQuery UI CSS files
                
      was (Author: fmeschbe):
    Applied the patch slightly modified in Rev. 1416228.

  * Use minified versions of JQuery und JQuery UI
  * Only use single minified jquery-ui.css file
  * Added debug profile build embedding non-minified versions of JQuery and JQuery UI as well as of the JQuery UI CSS files
                  
> Upgrade jquery-ui to 1.9.1
> --------------------------
>
>                 Key: FELIX-3770
>                 URL: https://issues.apache.org/jira/browse/FELIX-3770
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Assignee: Felix Meschberger
>             Fix For: webconsole-4.0.2
>
>         Attachments: FELIX-3770.tar.gz, main_header.html.patch.txt
>
>
> It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504614#comment-13504614 ] 

Felix Meschberger commented on FELIX-3770:
------------------------------------------

Thanks for the archive. We generally prefer real patches (not modified classes in full packaged in a ZIP) because this helps analyzing the differences.

You can create a patch easily using the svn diff command or using the "create patch" functionality in your IDE. 
                
> Upgrade jquery-ui to 1.9.1
> --------------------------
>
>                 Key: FELIX-3770
>                 URL: https://issues.apache.org/jira/browse/FELIX-3770
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>         Attachments: FELIX-3770.tar.gz
>
>
> It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saginor updated FELIX-3770:
---------------------------------

    Attachment: FELIX-3770.tar.gz

Attaching resources that need to be added or modified to upgrade JQuery UI.
                
> Upgrade jquery-ui to 1.9.1
> --------------------------
>
>                 Key: FELIX-3770
>                 URL: https://issues.apache.org/jira/browse/FELIX-3770
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>         Attachments: FELIX-3770.tar.gz
>
>
> It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503633#comment-13503633 ] 

Henry Saginor commented on FELIX-3770:
--------------------------------------

The attachment contains the following:
src/main/resources/res/lib/jquery-1.8.3.js 
src/main/resources/res/lib/jquery-ui-1.9.2.js 
src/main/resources/res/lib/themes/base-1.9.2/ 
src/main/resources/templates/main_header.html

Note that I did not want to modify the existing base theme yet. So, I added one specifically of the upgrade.
The main_header.html was changed. I am not sure if any other templates need to be modified. This appears to handle the upgrade.

I tested this with existing plugins and so far I don't see any major backward compatibility problems. 
But when you open the Bundles plugin page there is a JavaScript error on line 303 in bundles.js:
t is undefined
if (t.sortList) {  
The code appears to be setting a cookie. Table sorting works btw. But it is not retained when you refresh. I am not sure if this is an existing bug or was caused by the JQuery upgrade.   
                
> Upgrade jquery-ui to 1.9.1
> --------------------------
>
>                 Key: FELIX-3770
>                 URL: https://issues.apache.org/jira/browse/FELIX-3770
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>         Attachments: FELIX-3770.tar.gz
>
>
> It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3770) Upgrade jquery-ui to 1.9.1

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saginor updated FELIX-3770:
---------------------------------

    Attachment: main_header.html.patch.txt

I am sorry. Attaching patch for main_header.html. All other files are new. But let me know if you want patches for all of them.
                
> Upgrade jquery-ui to 1.9.1
> --------------------------
>
>                 Key: FELIX-3770
>                 URL: https://issues.apache.org/jira/browse/FELIX-3770
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>         Attachments: FELIX-3770.tar.gz, main_header.html.patch.txt
>
>
> It's time to upgrade jquery-ui used by Web Console. JQuery UI 1.9.1 has new features like a menu widget that can be used to implement FELIX-3769. JQuery core should probably be upgraded as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira