You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Nick Dimiduk (Jira)" <ji...@apache.org> on 2024/10/07 09:43:00 UTC
[jira] [Reopened] (HBASE-28396) Quota throttling can cause a leak of scanners
[ https://issues.apache.org/jira/browse/HBASE-28396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Dimiduk reopened HBASE-28396:
----------------------------------
Reopening while we resolve the branch-2.6 compatibility issue flagged on the 2.6.1rc0 VOTE thread, https://lists.apache.org/thread/j3sv12msdcpk9sh4g7hq5v8q560zknjn
This one has no api incompatibility itself, it only needs an addendum in the event that HBASE-28346 is reverted.
> Quota throttling can cause a leak of scanners
> ---------------------------------------------
>
> Key: HBASE-28396
> URL: https://issues.apache.org/jira/browse/HBASE-28396
> Project: HBase
> Issue Type: Bug
> Reporter: Bryan Beaudreault
> Assignee: Hernan Gelaf-Romer
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2, 2.6.1
>
>
> In RSRpcServices.scan, we check the quota after having created a new RegionScannerHolder. If the quota is exceeded, an exception will be thrown. In this case, we can't send the scannerName back to the client because it's just an exception. So the client will be forced to retry the openScanner call, but the RegionScannerHolder is not closed. Eventually the scanners will be cleaned up by the lease expiration, but this could cause many scanners to leak during periods of high throttling.
> We could close the newly opened scanner before throwing the throttle exception, but I think it's better to not open the scanner at all until we've grabbed some quota.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)