You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Alex Brett <al...@citrix.com> on 2014/08/11 16:57:46 UTC
Review Request 24552: CLOUDSTACK-7307 Add simulator_only attribute to tests
which need it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24552/
-----------------------------------------------------------
Review request for cloudstack, Gaurav Aradhye and Santhosh Edukulla.
Bugs: CLOUDSTACK-7307
https://issues.apache.org/jira/browse/CLOUDSTACK-7307
Repository: cloudstack-git
Description
-------
See full explanation and justification of this patch on the ticket at https://issues.apache.org/jira/browse/CLOUDSTACK-7307
A brief summary is that a number of tests require the simulator (e.g. to check the behaviour in a failure condition).
The existing attempt at solving this issue involved setting the required_hardware attribute to "simulator only", however
this is not very easy to use with the nosetests runner due to limitations it has around handling attributes. By adding a
new attribute (simulator_only), we can simply add !simulator_only to an attribute listing to avoid running these tests.
Diffs
-----
test/integration/smoke/misc/test_deploy_vm.py 071d15d
test/integration/smoke/misc/test_vm_ha.py 601354e
test/integration/smoke/test_vm_sync.py 6d56945
Diff: https://reviews.apache.org/r/24552/diff/
Testing
-------
Verified that tests are picked up when run without the new attribute, and not picked up when used with !simulator_only in the nosetests -a attribute list.
Thanks,
Alex Brett
Re: Review Request 24552: CLOUDSTACK-7307 Add simulator_only
attribute to tests which need it
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24552/#review79035
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Aug. 11, 2014, 2:57 p.m., Alex Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24552/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 2:57 p.m.)
>
>
> Review request for cloudstack, Gaurav Aradhye and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7307
> https://issues.apache.org/jira/browse/CLOUDSTACK-7307
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> See full explanation and justification of this patch on the ticket at https://issues.apache.org/jira/browse/CLOUDSTACK-7307
>
> A brief summary is that a number of tests require the simulator (e.g. to check the behaviour in a failure condition).
>
> The existing attempt at solving this issue involved setting the required_hardware attribute to "simulator only", however
> this is not very easy to use with the nosetests runner due to limitations it has around handling attributes. By adding a
> new attribute (simulator_only), we can simply add !simulator_only to an attribute listing to avoid running these tests.
>
>
> Diffs
> -----
>
> test/integration/smoke/misc/test_deploy_vm.py 071d15d
> test/integration/smoke/misc/test_vm_ha.py 601354e
> test/integration/smoke/test_vm_sync.py 6d56945
>
> Diff: https://reviews.apache.org/r/24552/diff/
>
>
> Testing
> -------
>
> Verified that tests are picked up when run without the new attribute, and not picked up when used with !simulator_only in the nosetests -a attribute list.
>
>
> Thanks,
>
> Alex Brett
>
>
Re: Review Request 24552: CLOUDSTACK-7307 Add simulator_only
attribute to tests which need it
Posted by Gaurav Aradhye <ga...@clogeny.com>.
Santhosh, I agree with Alex here. We should adopt this new tag if it adds
to simplicity.
Good thing is minimal change is needed.
Regards,
Gaurav
On Mon, Aug 11, 2014 at 8:27 PM, Alex Brett <al...@citrix.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24552/
> Review request for cloudstack, Gaurav Aradhye and Santhosh Edukulla.
> By Alex Brett.
> *Bugs: * CLOUDSTACK-7307
> <https://issues.apache.org/jira/browse/CLOUDSTACK-7307>
> *Repository: * cloudstack-git
> Description
>
> See full explanation and justification of this patch on the ticket at https://issues.apache.org/jira/browse/CLOUDSTACK-7307
>
> A brief summary is that a number of tests require the simulator (e.g. to check the behaviour in a failure condition).
>
> The existing attempt at solving this issue involved setting the required_hardware attribute to "simulator only", however
> this is not very easy to use with the nosetests runner due to limitations it has around handling attributes. By adding a
> new attribute (simulator_only), we can simply add !simulator_only to an attribute listing to avoid running these tests.
>
> Testing
>
> Verified that tests are picked up when run without the new attribute, and not picked up when used with !simulator_only in the nosetests -a attribute list.
>
> Diffs
>
> - test/integration/smoke/misc/test_deploy_vm.py (071d15d)
> - test/integration/smoke/misc/test_vm_ha.py (601354e)
> - test/integration/smoke/test_vm_sync.py (6d56945)
>
> View Diff <https://reviews.apache.org/r/24552/diff/>
>