You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/08 17:45:22 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5444: serial/pty: Decouple SUSv1 style from pseudo fs operation
xiaoxiang781216 opened a new pull request #5444:
URL: https://github.com/apache/incubator-nuttx/pull/5444
## Summary
and always enable BSD style PTYs since this feature doesn't consume the additional code size
## Impact
SUSv1 style can work without pseudo fs operation
## Testing
adb shell on sim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5444: serial/pty: Decouple SUSv1 style from pseudo fs operation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-nuttx/pull/5444#discussion_r802244548
##########
File path: drivers/serial/Kconfig
##########
@@ -651,24 +651,9 @@ menuconfig PSEUDOTERM
if PSEUDOTERM
-choice
- prompt "PTY model"
- default PSEUDOTERM_BSD if DISABLE_PSEUDOFS_OPERATIONS
- default PSEUDOTERM_SUSV1 if !DISABLE_PSEUDOFS_OPERATIONS
-
-config PSEUDOTERM_BSD
- bool "BSD style"
- ---help---
- Deprecated BSD style PTYs.
-
- Master: /dev/ptyN
- Slave: /dev/ttypN
-
- Where N is the minor number
-
config PSEUDOTERM_SUSV1
Review comment:
Here is the possible combination:
1. Enable PSEDOTERM only->BSD style only
2. Enable PSEDOTERM plus PSEDOTERM_SUSV1->BSD and SUSv1 style
Since PSEUDOTERM_SUSV1 need an additional ptmx driver, user can disable this to save code size if they want. On the other hand, the additional consumption of BSD style is very small(a couple of if/else), it's more simple to enable it automatically if user already turn on PSEDOTERM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5444: serial/pty: Decouple SUSv1 style from pseudo fs operation
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-nuttx/pull/5444#discussion_r802012982
##########
File path: drivers/serial/Kconfig
##########
@@ -651,24 +651,9 @@ menuconfig PSEUDOTERM
if PSEUDOTERM
-choice
- prompt "PTY model"
- default PSEUDOTERM_BSD if DISABLE_PSEUDOFS_OPERATIONS
- default PSEUDOTERM_SUSV1 if !DISABLE_PSEUDOFS_OPERATIONS
-
-config PSEUDOTERM_BSD
- bool "BSD style"
- ---help---
- Deprecated BSD style PTYs.
-
- Master: /dev/ptyN
- Slave: /dev/ttypN
-
- Where N is the minor number
-
config PSEUDOTERM_SUSV1
Review comment:
Do we need `PSEUDOTERM_SUSV1` option now? It was one of the choice values and now seems that there is no choice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5444: serial/pty: Decouple SUSv1 style from pseudo fs operation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5444:
URL: https://github.com/apache/incubator-nuttx/pull/5444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5444: serial/pty: Decouple SUSv1 style from pseudo fs operation
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-nuttx/pull/5444#discussion_r802356213
##########
File path: drivers/serial/Kconfig
##########
@@ -651,24 +651,9 @@ menuconfig PSEUDOTERM
if PSEUDOTERM
-choice
- prompt "PTY model"
- default PSEUDOTERM_BSD if DISABLE_PSEUDOFS_OPERATIONS
- default PSEUDOTERM_SUSV1 if !DISABLE_PSEUDOFS_OPERATIONS
-
-config PSEUDOTERM_BSD
- bool "BSD style"
- ---help---
- Deprecated BSD style PTYs.
-
- Master: /dev/ptyN
- Slave: /dev/ttypN
-
- Where N is the minor number
-
config PSEUDOTERM_SUSV1
Review comment:
I see. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5444: serial/pty: Decouple SUSv1 style from pseudo fs operation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5444:
URL: https://github.com/apache/incubator-nuttx/pull/5444#issuecomment-1032900178
@acassis this patch continue the work at #5428 and finally decouple ptmx from pseudo operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org