[GitHub] spark pull request #20398: [SPARK-23221][SS][TEST] Fix KafkaContinuousSource...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20398#discussion_r163957587
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSourceSuite.scala ---
    @@ -87,6 +87,12 @@ class KafkaContinuousSourceTopicDeletionSuite extends KafkaContinuousTest {
     
     class KafkaContinuousSourceStressForDontFailOnDataLossSuite
         extends KafkaSourceStressForDontFailOnDataLossSuite {
    +
    +  override def createSparkSession(): TestSparkSession = {
    +    // Set maxRetries to 3 to handle NPE from `poll` when deleting a topic
    +    new TestSparkSession(new SparkContext("local[10,3]", "test-sql-context", sparkConf))
    --- End diff --
    
    Ur, sorry for this. While you are here, can we use more specific and different names instead `test-sql-context` for both suites?
    - `KafkaSourceStressForDontFailOnDataLossSuite`
    - `KafkaContinuousSourceStressForDontFailOnDataLossSuite`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org