You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "elguardian (via GitHub)" <gi...@apache.org> on 2024/05/29 08:50:54 UTC
[PR] [incubator-kie-issues-1277] Remove unused bpmn in jbpm-test [incubator-kie-kogito-runtimes]
elguardian opened a new pull request, #3536:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536
Closes : https://github.com/apache/incubator-kie-issues/issues/1277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1277] Remove unused bpmn in jbpm-test [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3536:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536#issuecomment-2137969509
**PR job** `#3` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/apache_migration/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3536/3/display/redirect
**Test results:**
- PASSED: 3259
- FAILED: 1
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/apache_migration/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3536/3/testReport/org.kie.kogito.persistence.kafka/KafkaProcessInstancesIT/testFindByIdReadMode/">org.kie.kogito.persistence.kafka.KafkaProcessInstancesIT.testFindByIdReadMode</a></summary>
Container startup failed for image vectorized/redpanda:v21.11.8
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1277] Remove unused bpmn in jbpm-test [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian merged PR #3536:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1277] Remove unused bpmn in jbpm-test [incubator-kie-kogito-runtimes]
Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler commented on code in PR #3536:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536#discussion_r1621080749
##########
jbpm/jbpm-tests/src/test/resources/correlationkey/Process1.bpmn2:
##########
Review Comment:
Would having [this test](https://github.com/apache/incubator-kie-kogito-runtimes/commit/b52f369328f543518f884e67d87c52ebec9ca151#diff-8614ba55a71e626287696e63f6d61aab335fb158f47ca350db1b3d8206acf455R2118) add any value now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1277] Remove unused bpmn in jbpm-test [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3536:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536#discussion_r1621791410
##########
jbpm/jbpm-tests/src/test/resources/correlationkey/Process1.bpmn2:
##########
Review Comment:
unfortunately that is for testing the business key generation. which a feature we don't have a replacement here. Not very sure how to translate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1277] Remove unused bpmn in jbpm-test [incubator-kie-kogito-runtimes]
Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler commented on code in PR #3536:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3536#discussion_r1622433344
##########
jbpm/jbpm-tests/src/test/resources/correlationkey/Process1.bpmn2:
##########
Review Comment:
thanks for the clarification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org