You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/02/04 18:15:00 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1306:
[HUDI-598] Update quick start page
lamber-ken opened a new pull request #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306
## What is the purpose of the pull request
1. Unify code indent ( 4 -> 2 )
2. Change `org.apache.hudi` to `hudi`
3. Fix hudi_ro_table not exists at Delete section
## Verify this pull request
**Compare changes**
- https://hudi.apache.org/docs/quick-start-guide.html
- https://lamber-ken.github.io/docs/quick-start-guide.html
## Committer checklist
- [X] Has a corresponding JIRA in PR title & commit
- [X] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on issue #1306: [HUDI-598]
Update quick start page
Posted by GitBox <gi...@apache.org>.
bhasudha commented on issue #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#issuecomment-596005465
Merging this since 0.5.1 doc release is cut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1306: [HUDI-598]
Update quick start page
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#issuecomment-583936293
hi @bhasudha, all review comments are addressed and fixed. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1306: [HUDI-598]
Update quick start page
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#issuecomment-582246372
Hi @bhasudha, I do and verify that "org.apache.hudi" to "hudi" https://github.com/apache/incubator-hudi/pull/1054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on issue #1306: [HUDI-598]
Update quick start page
Posted by GitBox <gi...@apache.org>.
bhasudha commented on issue #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#issuecomment-584021025
> hi @bhasudha, all review comments are addressed and fixed. :)
Hi @lamber-ken . I am having some doc changes that pertain to cutting 0.5.1 doc version directory. I ll send those PRs first and later merge this change so that 0.5.1 doc version does not contain newer changes.
The changes here looks okay. I am just waiting on those changes first to go in. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on a change in pull request
#1306: [HUDI-598] Update quick start page
Posted by GitBox <gi...@apache.org>.
bhasudha commented on a change in pull request #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#discussion_r374956098
##########
File path: docs/_docs/1_1_quick_start_guide.md
##########
@@ -176,28 +176,28 @@ Delete records for the HoodieKeys passed in.
```scala
// fetch total records count
-spark.sql("select uuid, partitionPath from hudi_ro_table").count()
+spark.sql("select uuid, partitionPath from hudi_trips_snapshot").count()
// fetch two records to be deleted
-val ds = spark.sql("select uuid, partitionPath from hudi_ro_table").limit(2)
+val ds = spark.sql("select uuid, partitionPath from hudi_trips_snapshot").limit(2)
// issue deletes
val deletes = dataGen.generateDeletes(ds.collectAsList())
val df = spark.read.json(spark.sparkContext.parallelize(deletes, 2));
-df.write.format("org.apache.hudi").
-options(getQuickstartWriteConfigs).
-option(OPERATION_OPT_KEY,"delete").
-option(PRECOMBINE_FIELD_OPT_KEY, "ts").
-option(RECORDKEY_FIELD_OPT_KEY, "uuid").
-option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
-option(TABLE_NAME, tableName).
-mode(Append).
-save(basePath);
+df.write.format("hudi").
+ options(getQuickstartWriteConfigs).
+ option(OPERATION_OPT_KEY,"delete").
+ option(PRECOMBINE_FIELD_OPT_KEY, "ts").
+ option(RECORDKEY_FIELD_OPT_KEY, "uuid").
+ option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
+ option(TABLE_NAME, tableName).
+ mode(Append).
+ save(basePath)
// run the same read query as above.
val roAfterDeleteViewDF = spark.
- read.
- format("org.apache.hudi").
- load(basePath + "/*/*/*/*")
+ read.
+ format("hudi").
+ load(basePath + "/*/*/*/*")
roAfterDeleteViewDF.registerTempTable("hudi_ro_table")
Review comment:
consider changing hudi_ro_table -> hudi_trips_snapshot here as well for consistency ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request
#1306: [HUDI-598] Update quick start page
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#discussion_r375064809
##########
File path: docs/_docs/1_1_quick_start_guide.md
##########
@@ -176,28 +176,28 @@ Delete records for the HoodieKeys passed in.
```scala
// fetch total records count
-spark.sql("select uuid, partitionPath from hudi_ro_table").count()
+spark.sql("select uuid, partitionPath from hudi_trips_snapshot").count()
// fetch two records to be deleted
-val ds = spark.sql("select uuid, partitionPath from hudi_ro_table").limit(2)
+val ds = spark.sql("select uuid, partitionPath from hudi_trips_snapshot").limit(2)
// issue deletes
val deletes = dataGen.generateDeletes(ds.collectAsList())
val df = spark.read.json(spark.sparkContext.parallelize(deletes, 2));
-df.write.format("org.apache.hudi").
-options(getQuickstartWriteConfigs).
-option(OPERATION_OPT_KEY,"delete").
-option(PRECOMBINE_FIELD_OPT_KEY, "ts").
-option(RECORDKEY_FIELD_OPT_KEY, "uuid").
-option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
-option(TABLE_NAME, tableName).
-mode(Append).
-save(basePath);
+df.write.format("hudi").
+ options(getQuickstartWriteConfigs).
+ option(OPERATION_OPT_KEY,"delete").
+ option(PRECOMBINE_FIELD_OPT_KEY, "ts").
+ option(RECORDKEY_FIELD_OPT_KEY, "uuid").
+ option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
+ option(TABLE_NAME, tableName).
+ mode(Append).
+ save(basePath)
// run the same read query as above.
val roAfterDeleteViewDF = spark.
- read.
- format("org.apache.hudi").
- load(basePath + "/*/*/*/*")
+ read.
+ format("hudi").
+ load(basePath + "/*/*/*/*")
roAfterDeleteViewDF.registerTempTable("hudi_ro_table")
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on a change in pull request
#1306: [HUDI-598] Update quick start page
Posted by GitBox <gi...@apache.org>.
bhasudha commented on a change in pull request #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#discussion_r374955592
##########
File path: docs/_docs/1_1_quick_start_guide.md
##########
@@ -176,28 +176,28 @@ Delete records for the HoodieKeys passed in.
```scala
// fetch total records count
-spark.sql("select uuid, partitionPath from hudi_ro_table").count()
+spark.sql("select uuid, partitionPath from hudi_trips_snapshot").count()
// fetch two records to be deleted
-val ds = spark.sql("select uuid, partitionPath from hudi_ro_table").limit(2)
+val ds = spark.sql("select uuid, partitionPath from hudi_trips_snapshot").limit(2)
// issue deletes
val deletes = dataGen.generateDeletes(ds.collectAsList())
val df = spark.read.json(spark.sparkContext.parallelize(deletes, 2));
-df.write.format("org.apache.hudi").
-options(getQuickstartWriteConfigs).
-option(OPERATION_OPT_KEY,"delete").
-option(PRECOMBINE_FIELD_OPT_KEY, "ts").
-option(RECORDKEY_FIELD_OPT_KEY, "uuid").
-option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
-option(TABLE_NAME, tableName).
-mode(Append).
-save(basePath);
+df.write.format("hudi").
+ options(getQuickstartWriteConfigs).
+ option(OPERATION_OPT_KEY,"delete").
+ option(PRECOMBINE_FIELD_OPT_KEY, "ts").
+ option(RECORDKEY_FIELD_OPT_KEY, "uuid").
+ option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
+ option(TABLE_NAME, tableName).
+ mode(Append).
+ save(basePath)
// run the same read query as above.
val roAfterDeleteViewDF = spark.
- read.
- format("org.apache.hudi").
- load(basePath + "/*/*/*/*")
+ read.
+ format("hudi").
+ load(basePath + "/*/*/*/*")
roAfterDeleteViewDF.registerTempTable("hudi_ro_table")
// fetch should return (total - 2) records
spark.sql("select uuid, partitionPath from hudi_ro_table").count()
Review comment:
hudi_ro_table -> hudi_trips_snapshot here as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1306: [HUDI-598]
Update quick start page
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#issuecomment-584027626
> > hi @bhasudha, all review comments are addressed and fixed. :)
>
> Hi @lamber-ken . I am having some doc changes that pertain to cutting 0.5.1 doc version directory. I ll send those PRs first and later merge this change so that 0.5.1 doc version does not contain newer changes.
>
> The changes here looks okay. I am just waiting on those changes first to go in. Thanks!
Okay, got. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha merged pull request #1306: [HUDI-598]
Update quick start page
Posted by GitBox <gi...@apache.org>.
bhasudha merged pull request #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1306:
[HUDI-598] Update quick start page
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1306: [HUDI-598] Update quick start page
URL: https://github.com/apache/incubator-hudi/pull/1306#issuecomment-582246372
Hi @bhasudha, I did and verify that "org.apache.hudi" to "hudi" https://github.com/apache/incubator-hudi/pull/1054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services