You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/10 09:04:58 UTC
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 7:04 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Summary (updated)
-----------------
Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3
src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63
src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review95129
-----------------------------------------------------------
src/master/master.hpp (lines 921 - 925)
<https://reviews.apache.org/r/37172/#comment149949>
I think we should move this backwards in the review chain (https://reviews.apache.org/r/37314/).
We can combine it with
```
hashmap<MachineInfo, mesos::maintenance::Mode> maintenanceStatuses;
```
(https://reviews.apache.org/r/37314/diff/1#1.6)
Possibly like:
```
struct MaintenanceInfo {
Unavailability unavailability;
mesos::maintenance::mode mode;
}
hashmap<MachineInfo, MaintenanceInfo> maintenanceInfos;
```
- Joseph Wu
On Aug. 10, 2015, 12:04 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 12:04 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 28356e4ca24312b8be0138a34805b3d9035a99a3
> src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63
> src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review96317
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:12 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/maintenance/maintenance.hpp PRE-CREATION
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review96365
-----------------------------------------------------------
After the TimeSpec change:
src/tests/master_maintenance_tests.cpp (line 258)
<https://reviews.apache.org/r/37172/#comment151695>
Might need a `static_cast<int64_t>` here.
src/tests/master_maintenance_tests.cpp (line 277)
<https://reviews.apache.org/r/37172/#comment151694>
Should be changed to an int comparison.
- Joseph Wu
On Aug. 24, 2015, 7:12 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 7:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/maintenance/maintenance.hpp PRE-CREATION
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review96808
-----------------------------------------------------------
Ship it!
src/master/master.hpp (lines 288 - 289)
<https://reviews.apache.org/r/37172/#comment152463>
s/Draining/DRAINING/
- Benjamin Hindman
On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/maintenance/maintenance.hpp PRE-CREATION
> src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review97524
-----------------------------------------------------------
Ship it!
LGTM.
(And I think BenH's issue is no longer present either.)
- Joseph Wu
On Sept. 2, 2015, 12:31 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review98796
-----------------------------------------------------------
Ship it!
Still looks good to me, but let's not forget the v1 API additions too please!
- Benjamin Hindman
On Sept. 13, 2015, 8:32 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:32 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:25 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Added comparison operators to v1 api.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
include/mesos/v1/mesos.hpp 0d695f36558fdc390461a8767a0c9db8e321a07a
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:32 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/maintenance/maintenance.hpp PRE-CREATION
src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/maintenance/maintenance.hpp PRE-CREATION
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review95869
-----------------------------------------------------------
src/tests/master_maintenance_tests.cpp (line 365)
<https://reviews.apache.org/r/37172/#comment151021>
s/machines/machine_infos/
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 11:57 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/maintenance/maintenance.hpp PRE-CREATION
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/#review95781
-----------------------------------------------------------
Ship it!
include/mesos/maintenance/maintenance.hpp (line 37)
<https://reviews.apache.org/r/37172/#comment150905>
Trailing whitespace.
src/master/master.hpp (lines 288 - 289)
<https://reviews.apache.org/r/37172/#comment150906>
Should we standardize how we refer to the maintenance modes in comments?
I've referred to the modes as pronouns [Normal, Draining, Deactivated]. We could change them all to be `screaming`-case. Or to pronoun-case.
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37172/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 11:57 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/maintenance/maintenance.hpp PRE-CREATION
> src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/master_maintenance_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37172: Maintenance Primitives: Set offer
`unavailability` if slave is scheduled for maintenance.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/maintenance/maintenance.hpp PRE-CREATION
src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37172/diff/
Testing
-------
Thanks,
Joris Van Remoortere